From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC44C46466 for ; Wed, 7 Oct 2020 01:58:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC69B208C3 for ; Wed, 7 Oct 2020 01:58:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="HhgczNI9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726791AbgJGB62 (ORCPT ); Tue, 6 Oct 2020 21:58:28 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:42662 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726623AbgJGB62 (ORCPT ); Tue, 6 Oct 2020 21:58:28 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1602035907; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=+o7MGsKHeGQlXkai/cG9FMjYngfTEsCZ2bNT3OvLsrk=; b=HhgczNI9156JEzXGI0A3l9JcpoSdbGHhUHLzwoiK46epgk262PY+pZdRXWbnklTX51IG8nT6 0oavNoKoWvhXG9mQnM+7AUUm/8An8fjCjw49J0PkBO3G7Xubi5QYllAmWwOn5p1Zz8SeRBje RMC9Igmp3ajN8wOVicrbKOhnawc= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI5ZDFmMiIsICJsaW51eC1wbUB2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 5f7d20c23711fec7b1aa16a5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 07 Oct 2020 01:58:26 GMT Sender: ilina=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 348B1C433CA; Wed, 7 Oct 2020 01:58:26 +0000 (UTC) Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ilina) by smtp.codeaurora.org (Postfix) with ESMTPSA id 21A9DC433CA; Wed, 7 Oct 2020 01:58:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 21A9DC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=ilina@codeaurora.org Date: Tue, 6 Oct 2020 19:58:24 -0600 From: Lina Iyer To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Ulf Hansson , Linux PM , linux-arm-msm Subject: Re: [PATCH v2] PM / Domains: enable domain idle state accounting Message-ID: <20201007015824.GB17917@codeaurora.org> References: <20201003155618.11997-1-ilina@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Oct 05 2020 at 07:27 -0600, Rafael J. Wysocki wrote: >On Sat, Oct 3, 2020 at 5:56 PM Lina Iyer wrote: >> >> To enable better debug of PM domains, let's keep a track of the success >> and rejections in entering each domain idle state. >> >> This statistics is exported in debugfs when reading the idle_states >> node, associated with each PM domain. >> >> Signed-off-by: Lina Iyer >> --- >> Changes in v2: >> - Renamed 'failed' to 'rejected' >> >> This patch depends-on: https://lkml.org/lkml/2020/9/24/465 >> --- >> drivers/base/power/domain.c | 7 +++++-- >> include/linux/pm_domain.h | 2 ++ >> 2 files changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c >> index f001ac6326fb..dbe89454f594 100644 >> --- a/drivers/base/power/domain.c >> +++ b/drivers/base/power/domain.c >> @@ -564,6 +564,7 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, >> >> genpd->status = GENPD_STATE_OFF; >> genpd_update_accounting(genpd); >> + genpd->states[genpd->state_idx].usage++; > >Why not to do this in genpd_update_accounting()? > That function is clubbed with debugfs and does heavy tracking using timers. This accounting is fairly basic and still quite useful for debugging. >> >> list_for_each_entry(link, &genpd->child_links, child_node) { >> genpd_sd_counter_dec(link->parent); >> @@ -574,6 +575,7 @@ static int genpd_power_off(struct generic_pm_domain *genpd, bool one_dev_on, >> >> return 0; >> busy: >> + genpd->states[genpd->state_idx].rejected++; >> if (nr_calls) >> __raw_notifier_call_chain(&genpd->power_notifiers, >> GENPD_STATE_ON, NULL, > >This doesn't apply to the current code, please rebase. > I believe it applies cleanly on top of https://lkml.org/lkml/2020/9/24/465, which I believe you are applied to your tree. Let me rebase and re-post. Sorry about that. Thanks, Lina >> @@ -3053,7 +3055,7 @@ static int idle_states_show(struct seq_file *s, void *data) >> if (ret) >> return -ERESTARTSYS; >> >> - seq_puts(s, "State Time Spent(ms)\n"); >> + seq_puts(s, "State Time Spent(ms) Usage Rejected\n"); >> >> for (i = 0; i < genpd->state_count; i++) { >> ktime_t delta = 0; >> @@ -3065,7 +3067,8 @@ static int idle_states_show(struct seq_file *s, void *data) >> >> msecs = ktime_to_ms( >> ktime_add(genpd->states[i].idle_time, delta)); >> - seq_printf(s, "S%-13i %lld\n", i, msecs); >> + seq_printf(s, "S%-13i %-14lld %-14llu %llu\n", i, msecs, >> + genpd->states[i].usage, genpd->states[i].rejected); >> } >> >> genpd_unlock(genpd); >> diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h >> index 3b2b561ce846..239647f2d27f 100644 >> --- a/include/linux/pm_domain.h >> +++ b/include/linux/pm_domain.h >> @@ -82,6 +82,8 @@ struct genpd_power_state { >> s64 power_off_latency_ns; >> s64 power_on_latency_ns; >> s64 residency_ns; >> + u64 usage; >> + u64 rejected; >> struct fwnode_handle *fwnode; >> ktime_t idle_time; >> void *data; >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project >>