From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D95C433E7 for ; Fri, 16 Oct 2020 04:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0718A20897 for ; Fri, 16 Oct 2020 04:24:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pUB8CQer" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729991AbgJPEYl (ORCPT ); Fri, 16 Oct 2020 00:24:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728261AbgJPEYk (ORCPT ); Fri, 16 Oct 2020 00:24:40 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A61FFC061755 for ; Thu, 15 Oct 2020 21:24:40 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id a17so669904pju.1 for ; Thu, 15 Oct 2020 21:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uaKvvL6PdvuvPajs37zVh2CeImIwjzJwYqgylaWoxvY=; b=pUB8CQerjb2zmESbX0G6SuhCl3QUeB4EULY1wT/0Hh77UQBS6X6oNyFo+/Iqonblk1 r+eYoSObbt+1c5koIh3AgKK4QM0KNWQBHJXVhI1vwIcDTFvD+1R+LVYfLysRqIKMZl3q VZv49M3y+shbySrHB7yJDOuGWor8D0ZO9mCcy58nxGrweN7rfG8DAYFWQkzptGJsXkfP iYd5M2R2wy5cgAct3z/Fw8GlC9o5IN4NxFFXGMe8jwtmamhKnp6evYhYzFzV09AENKeo /Aq/NhxUqnLMKziTUQK3Hue3ocYVdh3evC6gPRmus9bwGAGi6BAr3BAFEtW3Qbtfiny+ 6arg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uaKvvL6PdvuvPajs37zVh2CeImIwjzJwYqgylaWoxvY=; b=dZkY952RmFXywGFAs/wR4G+LSByILIzZGOV/9CA4OPY0o+SX2HE75zFAJVD9OgeTIR 2Ba9z19RS+xGJzFIGvY8JY3sZE1pWDuCzqUrxyg2jtFFqiPInLuKF3dkyEnpd+MeAlhe Ww71PUBimQtbbzDCeO94IjQadNZ5xnHpHypc3MKa4d7UEt1fdDLKBZceG8BBDI8N+csV gR4lBSmXVxawNle+qCsEoQzY27ekL1jiLlf7nDTK+CKVH+kIQGc+EG+opV7rWsy85zV8 LCHN3uV5x2cYMomUp6QA+yL8Zw1hZNpUBJOUMQ1MgRf7yjxj4hW1OLTw4oN+hw1w3hiG NCDw== X-Gm-Message-State: AOAM533tOLj0nvyb197fQunDnnOJmpb9s03P61yuoaiaMHQInAxuWvwP sl5ceqrIvyJ/KJZwoU8qplGbVqffIgtWJw== X-Google-Smtp-Source: ABdhPJzhJEsFB0UnUoCHcC0UKadXnmNTkz9N688VQi2sWpc8Yc4LkwwrVyObejrv3HZkmaIIMkX6rw== X-Received: by 2002:a17:902:9a89:b029:d5:ad3c:cf53 with SMTP id w9-20020a1709029a89b02900d5ad3ccf53mr2010788plp.8.1602822280078; Thu, 15 Oct 2020 21:24:40 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id q5sm912800pfb.184.2020.10.15.21.24.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2020 21:24:36 -0700 (PDT) Date: Fri, 16 Oct 2020 09:54:34 +0530 From: Viresh Kumar To: Sudeep Holla Cc: ulf.hansson@linaro.org, "Rafael J. Wysocki" , Kevin Hilman , Pavel Machek , Len Brown , Greg Kroah-Hartman , Viresh Kumar , Nishanth Menon , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, Vincent Guittot , nks@flawful.org, georgi.djakov@linaro.org, Stephan Gerhold , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201016042434.org6ibdqsqbzcdww@vireshk-i7> References: <24ff92dd1b0ee1b802b45698520f2937418f8094.1598260050.git.viresh.kumar@linaro.org> <20201015180555.gacdzkofpibkdn2e@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201015180555.gacdzkofpibkdn2e@bogus> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 15-10-20, 19:05, Sudeep Holla wrote: > OK, this breaks with SCMI which doesn't provide clocks but manage OPPs > directly. Before this change clk_get(dev..) was allowed to fail and > --EPROBE_DEFER was not an error. I think the change in itself is fine. We should be returning from there if we get EPROBE_DEFER. The question is rather why are you getting EPROBE_DEFER here ? > We use dev_pm_opp_add to add OPPs > read from the firmware and this change is preventing that. > > Sorry for checking this so late, but noticed only when this hit mainline. > > -- > Regards, > Sudeep -- viresh