linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional
@ 2020-10-21 16:42 Fabien Parent
  2020-10-21 16:42 ` [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC Fabien Parent
                   ` (4 more replies)
  0 siblings, 5 replies; 10+ messages in thread
From: Fabien Parent @ 2020-10-21 16:42 UTC (permalink / raw)
  To: linux-mediatek, linux-arm-kernel, linux-kernel, devicetree,
	linux-pm
  Cc: matthias.bgg, robh+dt, amitk, daniel.lezcano, rui.zhang,
	Fabien Parent

MT8516 Thermal IP does not support reset. Make the resets property
optional in order to be able to support MT8516 SoC.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 1e249c42fae0..2d20f6b0dca0 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -20,12 +20,12 @@ Required properties:
                        clocks are:
 		       "therm":	 Main clock needed for register access
 		       "auxadc": The AUXADC clock
-- resets: Reference to the reset controller controlling the thermal controller.
 - mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
 - mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
 - #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.
 
 Optional properties:
+- resets: Reference to the reset controller controlling the thermal controller.
 - nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
                unspecified default values shall be used.
 - nvmem-cell-names: Should be "calibration-data"
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC
  2020-10-21 16:42 [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Fabien Parent
@ 2020-10-21 16:42 ` Fabien Parent
  2020-10-26 14:49   ` Rob Herring
  2020-11-24  9:36   ` [thermal: thermal/next] " thermal-bot for Fabien Parent
  2020-10-21 16:42 ` [PATCH 3/3] thermal: mtk_thermal: make device_reset optional Fabien Parent
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 10+ messages in thread
From: Fabien Parent @ 2020-10-21 16:42 UTC (permalink / raw)
  To: linux-mediatek, linux-arm-kernel, linux-kernel, devicetree,
	linux-pm
  Cc: matthias.bgg, robh+dt, amitk, daniel.lezcano, rui.zhang,
	Fabien Parent

Add binding documentation for the MediaTek MT8516 SoC.
The SoC thermal IP is similar to MT2701.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 2d20f6b0dca0..5c7e7bdd029a 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -14,6 +14,7 @@ Required properties:
   - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
   - "mediatek,mt7622-thermal" : For MT7622 SoC
   - "mediatek,mt8183-thermal" : For MT8183 family of SoCs
+  - "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs
 - reg: Address range of the thermal controller
 - interrupts: IRQ for the thermal controller
 - clocks, clock-names: Clocks needed for the thermal controller. required
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] thermal: mtk_thermal: make device_reset optional
  2020-10-21 16:42 [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Fabien Parent
  2020-10-21 16:42 ` [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC Fabien Parent
@ 2020-10-21 16:42 ` Fabien Parent
  2020-10-27 10:11   ` Matthias Brugger
  2020-11-24  9:36   ` [thermal: thermal/next] " thermal-bot for Fabien Parent
  2020-10-26 14:49 ` [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Rob Herring
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 10+ messages in thread
From: Fabien Parent @ 2020-10-21 16:42 UTC (permalink / raw)
  To: linux-mediatek, linux-arm-kernel, linux-kernel, devicetree,
	linux-pm
  Cc: matthias.bgg, robh+dt, amitk, daniel.lezcano, rui.zhang,
	Fabien Parent

MT8516 does not support thermal reset. Use device_reset_optional
instead of device_reset.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 drivers/thermal/mtk_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 0bd7aa564bc2..149c6d7fd5a0 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -1052,7 +1052,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	ret = device_reset(&pdev->dev);
+	ret = device_reset_optional(&pdev->dev);
 	if (ret)
 		return ret;
 
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional
  2020-10-21 16:42 [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Fabien Parent
  2020-10-21 16:42 ` [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC Fabien Parent
  2020-10-21 16:42 ` [PATCH 3/3] thermal: mtk_thermal: make device_reset optional Fabien Parent
@ 2020-10-26 14:49 ` Rob Herring
  2020-10-27 10:19 ` Daniel Lezcano
  2020-11-24  9:36 ` [thermal: thermal/next] " thermal-bot for Fabien Parent
  4 siblings, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-10-26 14:49 UTC (permalink / raw)
  To: Fabien Parent
  Cc: devicetree, linux-kernel, daniel.lezcano, matthias.bgg,
	linux-arm-kernel, linux-mediatek, robh+dt, amitk, linux-pm,
	rui.zhang

On Wed, 21 Oct 2020 18:42:29 +0200, Fabien Parent wrote:
> MT8516 Thermal IP does not support reset. Make the resets property
> optional in order to be able to support MT8516 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC
  2020-10-21 16:42 ` [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC Fabien Parent
@ 2020-10-26 14:49   ` Rob Herring
  2020-11-24  9:36   ` [thermal: thermal/next] " thermal-bot for Fabien Parent
  1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2020-10-26 14:49 UTC (permalink / raw)
  To: Fabien Parent
  Cc: linux-kernel, matthias.bgg, robh+dt, linux-arm-kernel,
	daniel.lezcano, linux-pm, devicetree, linux-mediatek, amitk,
	rui.zhang

On Wed, 21 Oct 2020 18:42:30 +0200, Fabien Parent wrote:
> Add binding documentation for the MediaTek MT8516 SoC.
> The SoC thermal IP is similar to MT2701.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] thermal: mtk_thermal: make device_reset optional
  2020-10-21 16:42 ` [PATCH 3/3] thermal: mtk_thermal: make device_reset optional Fabien Parent
@ 2020-10-27 10:11   ` Matthias Brugger
  2020-11-24  9:36   ` [thermal: thermal/next] " thermal-bot for Fabien Parent
  1 sibling, 0 replies; 10+ messages in thread
From: Matthias Brugger @ 2020-10-27 10:11 UTC (permalink / raw)
  To: Fabien Parent, linux-mediatek, linux-arm-kernel, linux-kernel,
	devicetree, linux-pm
  Cc: robh+dt, amitk, daniel.lezcano, rui.zhang



On 21/10/2020 18:42, Fabien Parent wrote:
> MT8516 does not support thermal reset. Use device_reset_optional
> instead of device_reset.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/thermal/mtk_thermal.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 0bd7aa564bc2..149c6d7fd5a0 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -1052,7 +1052,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
>   		return -EINVAL;
>   	}
>   
> -	ret = device_reset(&pdev->dev);
> +	ret = device_reset_optional(&pdev->dev);
>   	if (ret)
>   		return ret;
>   
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional
  2020-10-21 16:42 [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Fabien Parent
                   ` (2 preceding siblings ...)
  2020-10-26 14:49 ` [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Rob Herring
@ 2020-10-27 10:19 ` Daniel Lezcano
  2020-11-24  9:36 ` [thermal: thermal/next] " thermal-bot for Fabien Parent
  4 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2020-10-27 10:19 UTC (permalink / raw)
  To: Fabien Parent, linux-mediatek, linux-arm-kernel, linux-kernel,
	devicetree, linux-pm
  Cc: matthias.bgg, robh+dt, amitk, rui.zhang

On 21/10/2020 18:42, Fabien Parent wrote:
> MT8516 Thermal IP does not support reset. Make the resets property
> optional in order to be able to support MT8516 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---

Applied, thanks




-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [thermal: thermal/next] thermal: mtk_thermal: make device_reset optional
  2020-10-21 16:42 ` [PATCH 3/3] thermal: mtk_thermal: make device_reset optional Fabien Parent
  2020-10-27 10:11   ` Matthias Brugger
@ 2020-11-24  9:36   ` thermal-bot for Fabien Parent
  1 sibling, 0 replies; 10+ messages in thread
From: thermal-bot for Fabien Parent @ 2020-11-24  9:36 UTC (permalink / raw)
  To: linux-pm
  Cc: Fabien Parent, Matthias Brugger, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     703456ba76e9449b5ade6597c04a90ee3421cd94
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//703456ba76e9449b5ade6597c04a90ee3421cd94
Author:        Fabien Parent <fparent@baylibre.com>
AuthorDate:    Wed, 21 Oct 2020 18:42:31 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 27 Oct 2020 11:19:18 +01:00

thermal: mtk_thermal: make device_reset optional

MT8516 does not support thermal reset. Use device_reset_optional
instead of device_reset.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201021164231.3029956-3-fparent@baylibre.com
---
 drivers/thermal/mtk_thermal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 0bd7aa5..149c6d7 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -1052,7 +1052,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	ret = device_reset(&pdev->dev);
+	ret = device_reset_optional(&pdev->dev);
 	if (ret)
 		return ret;
 

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [thermal: thermal/next] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC
  2020-10-21 16:42 ` [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC Fabien Parent
  2020-10-26 14:49   ` Rob Herring
@ 2020-11-24  9:36   ` thermal-bot for Fabien Parent
  1 sibling, 0 replies; 10+ messages in thread
From: thermal-bot for Fabien Parent @ 2020-11-24  9:36 UTC (permalink / raw)
  To: linux-pm; +Cc: Fabien Parent, Rob Herring, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     c707f973df1706020f4a4669b5f1932e90c0f29c
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//c707f973df1706020f4a4669b5f1932e90c0f29c
Author:        Fabien Parent <fparent@baylibre.com>
AuthorDate:    Wed, 21 Oct 2020 18:42:30 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 27 Oct 2020 11:18:54 +01:00

dt-bindings: thermal: mediatek: add documentation for MT8516 SoC

Add binding documentation for the MediaTek MT8516 SoC.
The SoC thermal IP is similar to MT2701.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201021164231.3029956-2-fparent@baylibre.com
---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 2d20f6b..5c7e7bd 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -14,6 +14,7 @@ Required properties:
   - "mediatek,mt2712-thermal" : For MT2712 family of SoCs
   - "mediatek,mt7622-thermal" : For MT7622 SoC
   - "mediatek,mt8183-thermal" : For MT8183 family of SoCs
+  - "mediatek,mt8516-thermal", "mediatek,mt2701-thermal : For MT8516 family of SoCs
 - reg: Address range of the thermal controller
 - interrupts: IRQ for the thermal controller
 - clocks, clock-names: Clocks needed for the thermal controller. required

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [thermal: thermal/next] dt-bindings: thermal: mediatek: make resets property optional
  2020-10-21 16:42 [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Fabien Parent
                   ` (3 preceding siblings ...)
  2020-10-27 10:19 ` Daniel Lezcano
@ 2020-11-24  9:36 ` thermal-bot for Fabien Parent
  4 siblings, 0 replies; 10+ messages in thread
From: thermal-bot for Fabien Parent @ 2020-11-24  9:36 UTC (permalink / raw)
  To: linux-pm; +Cc: Fabien Parent, Rob Herring, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     07df39d03c34bd7baf4c26e41a5dd92ec56e9081
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//07df39d03c34bd7baf4c26e41a5dd92ec56e9081
Author:        Fabien Parent <fparent@baylibre.com>
AuthorDate:    Wed, 21 Oct 2020 18:42:29 +02:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 27 Oct 2020 11:18:29 +01:00

dt-bindings: thermal: mediatek: make resets property optional

MT8516 Thermal IP does not support reset. Make the resets property
optional in order to be able to support MT8516 SoC.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201021164231.3029956-1-fparent@baylibre.com
---
 Documentation/devicetree/bindings/thermal/mediatek-thermal.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
index 1e249c4..2d20f6b 100644
--- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt
@@ -20,12 +20,12 @@ Required properties:
                        clocks are:
 		       "therm":	 Main clock needed for register access
 		       "auxadc": The AUXADC clock
-- resets: Reference to the reset controller controlling the thermal controller.
 - mediatek,auxadc: A phandle to the AUXADC which the thermal controller uses
 - mediatek,apmixedsys: A phandle to the APMIXEDSYS controller.
 - #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.
 
 Optional properties:
+- resets: Reference to the reset controller controlling the thermal controller.
 - nvmem-cells: A phandle to the calibration data provided by a nvmem device. If
                unspecified default values shall be used.
 - nvmem-cell-names: Should be "calibration-data"

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-11-24  9:37 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-21 16:42 [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Fabien Parent
2020-10-21 16:42 ` [PATCH 2/3] dt-bindings: thermal: mediatek: add documentation for MT8516 SoC Fabien Parent
2020-10-26 14:49   ` Rob Herring
2020-11-24  9:36   ` [thermal: thermal/next] " thermal-bot for Fabien Parent
2020-10-21 16:42 ` [PATCH 3/3] thermal: mtk_thermal: make device_reset optional Fabien Parent
2020-10-27 10:11   ` Matthias Brugger
2020-11-24  9:36   ` [thermal: thermal/next] " thermal-bot for Fabien Parent
2020-10-26 14:49 ` [PATCH 1/3] dt-bindings: thermal: mediatek: make resets property optional Rob Herring
2020-10-27 10:19 ` Daniel Lezcano
2020-11-24  9:36 ` [thermal: thermal/next] " thermal-bot for Fabien Parent

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).