linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Cristian Marussi <cristian.marussi@arm.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] cpufreq: scmi: Fix OPP addition failure with a dummy clock provider
Date: Tue, 17 Nov 2020 10:05:32 +0530	[thread overview]
Message-ID: <20201117043532.xo2ks6zy73dujnbq@vireshk-i7> (raw)
In-Reply-To: <20201110111040.280231-1-sudeep.holla@arm.com>

On 10-11-20, 11:10, Sudeep Holla wrote:
> Commit dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return
> -EPROBE_DEFER") handles -EPROBE_DEFER for the clock/interconnects within
> _allocate_opp_table() which is called from dev_pm_opp_add and it
> now propagates the error back to the caller.
> 
> SCMI performance domain re-used clock bindings to keep it simple. However
> with the above mentioned change, if clock property is present in a device
> node, opps fails to get added with below errors until clk_get succeeds.
> 
>  cpu0: failed to add opp 450000000Hz
>  cpu0: failed to add opps to the device
>  ....(errors on cpu1-cpu4)
>  cpu5: failed to add opp 450000000Hz
>  cpu5: failed to add opps to the device
> 
> So, in order to fix the issue, we need to register dummy clock provider.
> With the dummy clock provider, clk_get returns NULL(no errors!), then opp
> core proceeds to add OPPs for the CPUs.
> 
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Fixes: dd461cd9183f ("opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER")
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/cpufreq/scmi-cpufreq.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied. Thanks.

-- 
viresh

      parent reply	other threads:[~2020-11-17  4:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 11:10 [PATCH] cpufreq: scmi: Fix OPP addition failure with a dummy clock provider Sudeep Holla
2020-11-10 11:24 ` Viresh Kumar
2020-11-11 11:05   ` Sudeep Holla
2020-11-17  4:35 ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117043532.xo2ks6zy73dujnbq@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).