From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390B4C63777 for ; Wed, 25 Nov 2020 08:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2810208C3 for ; Wed, 25 Nov 2020 08:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728168AbgKYIJT (ORCPT ); Wed, 25 Nov 2020 03:09:19 -0500 Received: from mga14.intel.com ([192.55.52.115]:60172 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726788AbgKYIJT (ORCPT ); Wed, 25 Nov 2020 03:09:19 -0500 IronPort-SDR: SlnXGnSGkSdPCCEpHYOiEpvuLYvA0gXzSxps7l0KtTmV+7xriM3irRWbRDVh7HU5odNeUyGLbD 8AEbZtt3BrPg== X-IronPort-AV: E=McAfee;i="6000,8403,9815"; a="171308887" X-IronPort-AV: E=Sophos;i="5.78,368,1599548400"; d="scan'208";a="171308887" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2020 00:09:18 -0800 IronPort-SDR: 86ykC7dgvOHKt2RYbLrc+JeVaxAzHUL73SvgE0Ig+dHLXnxBUW3yvpM2Bxo5qmUV1elo+vb50H B8z52QfRh9hA== X-IronPort-AV: E=Sophos;i="5.78,368,1599548400"; d="scan'208";a="362239650" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Nov 2020 00:09:12 -0800 Received: by lahna (sSMTP sendmail emulation); Wed, 25 Nov 2020 10:09:10 +0200 Date: Wed, 25 Nov 2020 10:09:10 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Linux ACPI , LKML , Linux PM , Linux PCI , "Rafael J. Wysocki" , Bjorn Helgaas , Kai-Heng Feng Subject: Re: [PATCH v1 2/2] PM: ACPI: Refresh wakeup device power configuration every time Message-ID: <20201125080910.GC2532@lahna.fi.intel.com> References: <27714988.CF3CpBaniU@kreacher> <1717218.WU8ttdIIEu@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1717218.WU8ttdIIEu@kreacher> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Nov 24, 2020 at 08:46:38PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > When wakeup signaling is enabled for a bridge for the second (or every > next) time in a row, its existing device wakeup power configuration > may not match the new conditions. For example, some devices below > it may have been put into low-power states and that changes the > device wakeup power conditions or similar. This causes functional > problems to appear on some systems (for example, because of it the > Thunderbolt port on Dell Precision 5550 cannot detect devices plugged > in after it has been suspended). > > For this reason, modify __acpi_device_wakeup_enable() to refresh the > device wakeup power configuration of the target device on every > invocation, not just when it is called for that device first time > in a row. > > Signed-off-by: Rafael J. Wysocki > Reported-by: Kai-Heng Feng > Tested-by: Kai-Heng Feng Reviewed-by: Mika Westerberg