From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C3FC71155 for ; Wed, 2 Dec 2020 20:15:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C9BC2224A for ; Wed, 2 Dec 2020 20:15:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729213AbgLBUPI (ORCPT ); Wed, 2 Dec 2020 15:15:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:60266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728868AbgLBUPI (ORCPT ); Wed, 2 Dec 2020 15:15:08 -0500 Date: Wed, 2 Dec 2020 14:14:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1606940067; bh=BnksKH2mu/AIusjM7w3qtsMo+YYe0Fmuw1JBYItwDJ8=; h=From:To:Cc:Subject:In-Reply-To:From; b=eATGBHy5IcBoesjh68RbtIiCHyqzTkB62ErRCXv22EQl+qt05Tqmu3AFQ95XBrm9B XggkOfC5NEf86set8LG4s8thG/fWEoLCnDJc1SDhJ4vsUNTnxLzXhCo0M5vK4GF5lk x+YTYbHX6NpK/ZVroc0c31Jf0mQ7kF3PGcTAQ7woi7xcCPUIRKUyLWco9AK1ifE/Sw IhLkVnUMz600t/kIOmaKdlcP/ZG+UegPpp8RvG1qhwmdLwSLADBJA7mhpuqYeq6Pyf 78y3wXGPl7dCNj/OQPShj9sAdCGQg+PHKPHDZN2ZEnfoBXqLO/FZIws5VtA1HS689s dy7qS9cKxHj8A== From: Bjorn Helgaas To: "Limonciello, Mario" Cc: Jakub Kicinski , Tony Nguyen , "intel-wired-lan@lists.osuosl.org" , Linux PM , Netdev , Alexander Duyck , Sasha Netfin , Aaron Brown , Stefan Assmann , David Miller , "darcari@redhat.com" , "Shen, Yijun" , "Yuan, Perry" Subject: Re: [PATCH v2 0/5] Improve s0ix flows for systems i219LM Message-ID: <20201202201425.GA1467301@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Dec 02, 2020 at 07:24:28PM +0000, Limonciello, Mario wrote: > > -----Original Message----- > > From: Jakub Kicinski > > Sent: Wednesday, December 2, 2020 13:07 > > To: Limonciello, Mario > > Cc: Tony Nguyen; intel-wired-lan@lists.osuosl.org; Linux PM; Netdev; Alexander > > Duyck; Sasha Netfin; Aaron Brown; Stefan Assmann; David Miller; > > darcari@redhat.com; Shen, Yijun; Yuan, Perry > > Subject: Re: [PATCH v2 0/5] Improve s0ix flows for systems i219LM > > > > > > [EXTERNAL EMAIL] > > > > On Wed, 2 Dec 2020 10:17:43 -0600 Mario Limonciello wrote: > > > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > > systems") > > > disabled s0ix flows for systems that have various incarnations of the > > > i219-LM ethernet controller. This was done because of some regressions > > > caused by an earlier > > > commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable connected case") > > > with i219-LM controller. > > > > > > Performing suspend to idle with these ethernet controllers requires a > > properly > > > configured system. To make enabling such systems easier, this patch > > > series allows turning on using ethtool. > > > > > > The flows have also been confirmed to be configured correctly on Dell's > > Latitude > > > and Precision CML systems containing the i219-LM controller, when the kernel > > also > > > contains the fix for s0i3.2 entry previously submitted here: > > > https://marc.info/?l=linux-netdev&m=160677194809564&w=2 > > > > > > Patches 3 and 4 will turn the behavior on by default for Dell's CML systems. > > > Patch 5 allows accessing the value of the flags via ethtool to tell if the > > > heuristics have turned on s0ix flows, as well as for development purposes > > > to determine if a system should be added to the heuristics list. > > > > I don't see PCI or Bjorn Helgaas CCed. > > > > You can drop linux-kernel tho. > > Correct, that was intentional that PCI (and Bjorn) weren't added. Since I came > up with a way to detect platforms without DMI as suggested and this is entirely > controlling a driver behavior within e1000e only on systems with i219-LM I > didn't think that PCI ML was actually needed. > > Since you disagree, I'll add Bjorn into this thread. > > @Bjorn Helgaas, > > Apologies that you're looped in this way rather than directly to the submission, > but the cover letter is above and the patch series can be viewed at this patchwork > if you would like to fetch the mbox and respond to provide any comments. > > https://patchwork.ozlabs.org/project/netdev/list/?series=218121 > > I'll include you directly if any future v3 is necessary. No need, I don't think. AFAICT there's nothing there related to the PCI core. Thanks! Bjorn