From: Fabio Estevam <festevam@gmail.com>
To: daniel.lezcano@linaro.org
Cc: Anson.Huang@nxp.com, linux-pm@vger.kernel.org,
Fabio Estevam <festevam@gmail.com>
Subject: [PATCH 1/2] thermal: imx8mm: Print the correct error code
Date: Wed, 2 Dec 2020 20:24:47 -0300 [thread overview]
Message-ID: <20201202232448.2692-1-festevam@gmail.com> (raw)
Currently the error message does not print the correct error code.
Fix it by initializing 'ret' to the proper error code.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/thermal/imx8mm_thermal.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
index a1e4f9bb4cb0..ce7cb6452c52 100644
--- a/drivers/thermal/imx8mm_thermal.c
+++ b/drivers/thermal/imx8mm_thermal.c
@@ -166,10 +166,11 @@ static int imx8mm_tmu_probe(struct platform_device *pdev)
&tmu->sensors[i],
&tmu_tz_ops);
if (IS_ERR(tmu->sensors[i].tzd)) {
+ ret = PTR_ERR(tmu->sensors[i].tzd);
dev_err(&pdev->dev,
"failed to register thermal zone sensor[%d]: %d\n",
i, ret);
- return PTR_ERR(tmu->sensors[i].tzd);
+ return ret;
}
tmu->sensors[i].hw_id = i;
}
--
2.17.1
next reply other threads:[~2020-12-02 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:24 Fabio Estevam [this message]
2020-12-02 23:24 ` [PATCH 2/2] thermal: imx8mm: Disable the clock on probe failure Fabio Estevam
2020-12-07 13:47 ` [thermal: thermal/next] " thermal-bot for Fabio Estevam
2020-12-07 13:47 ` [thermal: thermal/next] thermal: imx8mm: Print the correct error code thermal-bot for Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202232448.2692-1-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=Anson.Huang@nxp.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).