From: Chen Yu <yu.c.chen@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2][v2] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram
Date: Thu, 3 Dec 2020 11:44:43 +0800 [thread overview]
Message-ID: <20201203034443.GA4385@chenyu-office.sh.intel.com> (raw)
In-Reply-To: <ce83589757381a790153bd5947ea1f9346415102.1606370334.git.yu.c.chen@intel.com>
On Thu, Nov 26, 2020 at 02:14:40PM +0800, Chen Yu wrote:
> The NIC is put in runtime suspend status when there is no cable connected.
> As a result, it is safe to keep non-wakeup NIC in runtime suspended during
> s2ram because the system does not rely on the NIC plug event nor WoL to wake
> up the system. Besides that, unlike the s2idle, s2ram does not need to
> manipulate S0ix settings during suspend.
>
> This patch assigns DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME
> to the e1000e driver so that the s2ram could skip the .suspend_late(),
> .suspend_noirq() and .resume_noirq() .resume_early() when possible.
> Also skip .suspend() and .resume() if dev_pm_skip_suspend() and
> dev_pm_skip_resume() return true, so as to speed up the suspend and
> resume during s2ram.
>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
> v2: Added test data and some commit log revise(Paul Menzel)
> Only skip the suspend/resume if the NIC is not a wake up device specified
> by the user(Kai-Heng Feng)
>
Deprecated and replaced by v3.
thanks,
Chenyu
next prev parent reply other threads:[~2020-12-03 3:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 6:14 [PATCH 0/2][v2] Leverage runtime suspend to speed up the s2ram on e1000e Chen Yu
2020-11-26 6:14 ` [PATCH 1/2][v2] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram Chen Yu
2020-12-03 3:44 ` Chen Yu [this message]
2020-11-26 6:14 ` [PATCH 2/2][v2] e1000e: Remove the runtime suspend restriction on CNP+ Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203034443.GA4385@chenyu-office.sh.intel.com \
--to=yu.c.chen@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).