From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB014C64E7C for ; Thu, 3 Dec 2020 03:42:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B57C21D91 for ; Thu, 3 Dec 2020 03:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbgLCDmh (ORCPT ); Wed, 2 Dec 2020 22:42:37 -0500 Received: from mga01.intel.com ([192.55.52.88]:57474 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbgLCDmg (ORCPT ); Wed, 2 Dec 2020 22:42:36 -0500 IronPort-SDR: GBEn5/3SQW/WqAXIStfaeVQeoxITny9CmblOW+CQp7vBpxOOslVFBHX8OqWYxX12gxE9pm4CZ0 gXZpeTZCXO4w== X-IronPort-AV: E=McAfee;i="6000,8403,9823"; a="191353387" X-IronPort-AV: E=Sophos;i="5.78,388,1599548400"; d="scan'208";a="191353387" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 19:41:56 -0800 IronPort-SDR: W79kZWISrCH+wcSWKMBeXeCvrM8VO6Ip9erwsxvSoxWbvPMzMkwbI+y5OYzZL6uzPuuTubpAB5 y1JUfxs9S/rg== X-IronPort-AV: E=Sophos;i="5.78,388,1599548400"; d="scan'208";a="481807881" Received: from chenyu-office.sh.intel.com ([10.239.158.173]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 19:41:55 -0800 Date: Thu, 3 Dec 2020 11:44:43 +0800 From: Chen Yu To: "Rafael J. Wysocki" , Kai-Heng Feng Cc: linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2][v2] e1000e: Assign DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME to speed up s2ram Message-ID: <20201203034443.GA4385@chenyu-office.sh.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Nov 26, 2020 at 02:14:40PM +0800, Chen Yu wrote: > The NIC is put in runtime suspend status when there is no cable connected. > As a result, it is safe to keep non-wakeup NIC in runtime suspended during > s2ram because the system does not rely on the NIC plug event nor WoL to wake > up the system. Besides that, unlike the s2idle, s2ram does not need to > manipulate S0ix settings during suspend. > > This patch assigns DPM_FLAG_SMART_SUSPEND and DPM_FLAG_MAY_SKIP_RESUME > to the e1000e driver so that the s2ram could skip the .suspend_late(), > .suspend_noirq() and .resume_noirq() .resume_early() when possible. > Also skip .suspend() and .resume() if dev_pm_skip_suspend() and > dev_pm_skip_resume() return true, so as to speed up the suspend and > resume during s2ram. > > Signed-off-by: Chen Yu > --- > v2: Added test data and some commit log revise(Paul Menzel) > Only skip the suspend/resume if the NIC is not a wake up device specified > by the user(Kai-Heng Feng) > Deprecated and replaced by v3. thanks, Chenyu