[PATCH v4 0/5] imx8mq: updates for the interconnect fabric

[PATCH v4 0/5] imx8mq: updates for the interconnect fabric

[Martin Kepplinger]

revision history:
v4: (thanks Shawn, Georgi and Greg)
 * reorder to have dt-bindings doc before code addition
 * add newline between dt nodes
 * removed "interconnect: imx8mq: Use icc_sync_state" from the patchset
   since it's part of gregkh/char-misc.git
 * Add acks

v3: (thanks Krysztof and Georgi)
 * drop the defconfig cycling patch and fix the interconnect enable config
 * add the noc node to imx8mq only
 * add missing signed-off-by
 * https://lore.kernel.org/linux-arm-kernel/20201210100906.18205-1-martin.kepplinger@puri.sm/T/#t

v2: (thanks Lucas)
 * reorder and clean up defconfig changes
 * use "dram" for the interconnect path name and document it
 * https://lore.kernel.org/linux-arm-kernel/20201201123932.12312-1-martin.kepplinger@puri.sm/T/#t

v1:
 * https://lore.kernel.org/linux-arm-kernel/20201201100124.4676-1-martin.kepplinger@puri.sm/T/#t

thanks,
                        martin


Leonard Crestez (1):
  arm64: dts: imx8mq: Add NOC node

Martin Kepplinger (4):
  arm64: dts: imx8mq: Add interconnect provider property
  dt-bindings: mxsfb: Add interconnect bindings for LCDIF path
  arm64: dts: imx8mq: Add interconnect for lcdif
  arm64: defconfig: Enable interconnect for imx8mq

 .../devicetree/bindings/display/mxsfb.txt     |  6 ++++
 arch/arm64/boot/dts/freescale/imx8mq.dtsi     | 28 +++++++++++++++++++
 arch/arm64/configs/defconfig                  |  2 ++
 3 files changed, 36 insertions(+)

-- 
2.20.1

[PATCH v4 1/5] arm64: dts: imx8mq: Add NOC node

[Martin Kepplinger]

From: Leonard Crestez <leonard.crestez@nxp.com>

Add initial support for dynamic frequency scaling of the main NOC
on imx8mq.

Make DDRC the parent of the NOC (using passive governor) so that the
main NOC is automatically scaled together with DDRC by default.

Support for proactive scaling via interconnect will come on top.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Acked-by: Georgi Djakov <georgi.djakov@linaro.org>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 24 +++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index a841a023e8e0..dbe480a76aa1 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1158,6 +1158,30 @@
 			};
 		};
 
+		noc: interconnect@32700000 {
+			compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc";
+			reg = <0x32700000 0x100000>;
+			clocks = <&clk IMX8MQ_CLK_NOC>;
+			fsl,ddrc = <&ddrc>;
+			operating-points-v2 = <&noc_opp_table>;
+
+			noc_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-133M {
+					opp-hz = /bits/ 64 <133333333>;
+				};
+
+				opp-400M {
+					opp-hz = /bits/ 64 <400000000>;
+				};
+
+				opp-800M {
+					opp-hz = /bits/ 64 <800000000>;
+				};
+			};
+		};
+
 		bus@32c00000 { /* AIPS4 */
 			compatible = "fsl,aips-bus", "simple-bus";
 			reg = <0x32c00000 0x400000>;
-- 
2.20.1

Re: [PATCH v4 1/5] arm64: dts: imx8mq: Add NOC node

[Shawn Guo]

On Thu, Jan 07, 2021 at 01:17:50PM +0100, Martin Kepplinger wrote:
> From: Leonard Crestez <leonard.crestez@nxp.com>
> 
> Add initial support for dynamic frequency scaling of the main NOC
> on imx8mq.
> 
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
> 
> Support for proactive scaling via interconnect will come on top.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> Acked-by: Georgi Djakov <georgi.djakov@linaro.org>

Applied, thanks.

[PATCH v4 2/5] arm64: dts: imx8mq: Add interconnect provider property

[Martin Kepplinger]

Add #interconnect-cells on main &noc so that it will probe the interconnect
provider.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Acked-by: Georgi Djakov <georgi.djakov@linaro.org>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index dbe480a76aa1..89e7de2e7f7a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1163,6 +1163,7 @@
 			reg = <0x32700000 0x100000>;
 			clocks = <&clk IMX8MQ_CLK_NOC>;
 			fsl,ddrc = <&ddrc>;
+			#interconnect-cells = <1>;
 			operating-points-v2 = <&noc_opp_table>;
 
 			noc_opp_table: opp-table {
-- 
2.20.1

[PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

[Martin Kepplinger]

Add optional interconnect properties for the dram path requests.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
index c985871c46b3..d494a2674290 100644
--- a/Documentation/devicetree/bindings/display/mxsfb.txt
+++ b/Documentation/devicetree/bindings/display/mxsfb.txt
@@ -15,6 +15,12 @@ Required properties:
     - "pix" for the LCDIF block clock
     - (MX6SX-only) "axi", "disp_axi" for the bus interface clock
 
+Optional properties:
+- interconnects : interconnect path specifier for LCDIF according to
+		Documentation/devicetree/bindings/interconnect/interconnect.txt.
+- interconnect-names: the name describing the interconnect path.
+		Should be "dram" for i.MX8MQ.
+
 Required sub-nodes:
   - port: The connection to an encoder chip.
 
-- 
2.20.1

[PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif

[Martin Kepplinger]

Add interconnect ports for lcdif to set bus capabilities.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 89e7de2e7f7a..9300be8c9b53 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -11,6 +11,7 @@
 #include "dt-bindings/input/input.h"
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/thermal/thermal.h>
+#include <dt-bindings/interconnect/imx8mq.h>
 #include "imx8mq-pinfunc.h"
 
 / {
@@ -522,6 +523,8 @@
 						  <&clk IMX8MQ_VIDEO_PLL1>,
 						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
 				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
+				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
+				interconnect-names = "dram";
 				status = "disabled";
 
 				port@0 {
-- 
2.20.1

Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif

[Shawn Guo]

On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 89e7de2e7f7a..9300be8c9b53 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>  #include "dt-bindings/input/input.h"
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/thermal/thermal.h>
> +#include <dt-bindings/interconnect/imx8mq.h>
>  #include "imx8mq-pinfunc.h"
>  
>  / {
> @@ -522,6 +523,8 @@
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> +				interconnect-names = "dram";

Hmm, two interconnect phandles but only one name?

Shawn

>  				status = "disabled";
>  
>  				port@0 {
> -- 
> 2.20.1
> 

Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif

[Martin Kepplinger]

On 15.01.21 10:47, Shawn Guo wrote:
> On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
>> Add interconnect ports for lcdif to set bus capabilities.
>>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> index 89e7de2e7f7a..9300be8c9b53 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
>> @@ -11,6 +11,7 @@
>>   #include "dt-bindings/input/input.h"
>>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>>   #include <dt-bindings/thermal/thermal.h>
>> +#include <dt-bindings/interconnect/imx8mq.h>
>>   #include "imx8mq-pinfunc.h"
>>   
>>   / {
>> @@ -522,6 +523,8 @@
>>   						  <&clk IMX8MQ_VIDEO_PLL1>,
>>   						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>>   				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
>> +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
>> +				interconnect-names = "dram";
> 
> Hmm, two interconnect phandles but only one name?
> 

Well it's one interconnect path that would more accurately be named 
"lcdif-dram" if that's what you mean. I removed "lcdif-" because it's 
the lcdif node, but maybe we should name it lcdif-dram after all. at 
least that's how others describe it.

                               martin

Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif

[Shawn Guo]

On Fri, Jan 15, 2021 at 10:57:02AM +0100, Martin Kepplinger wrote:
> 
> 
> On 15.01.21 10:47, Shawn Guo wrote:
> > On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> > > Add interconnect ports for lcdif to set bus capabilities.
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > > ---
> > >   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > index 89e7de2e7f7a..9300be8c9b53 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > @@ -11,6 +11,7 @@
> > >   #include "dt-bindings/input/input.h"
> > >   #include <dt-bindings/interrupt-controller/arm-gic.h>
> > >   #include <dt-bindings/thermal/thermal.h>
> > > +#include <dt-bindings/interconnect/imx8mq.h>
> > >   #include "imx8mq-pinfunc.h"
> > >   / {
> > > @@ -522,6 +523,8 @@
> > >   						  <&clk IMX8MQ_VIDEO_PLL1>,
> > >   						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
> > >   				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> > > +				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> > > +				interconnect-names = "dram";
> > 
> > Hmm, two interconnect phandles but only one name?
> > 
> 
> Well it's one interconnect path that would more accurately be named
> "lcdif-dram" if that's what you mean. I removed "lcdif-" because it's the
> lcdif node, but maybe we should name it lcdif-dram after all. at least
> that's how others describe it.

Ha, sorry, I misunderstood the interconnects property.

Shawn

Re: [PATCH v4 4/5] arm64: dts: imx8mq: Add interconnect for lcdif

[Shawn Guo]

On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

Applied, thanks.

[PATCH v4 5/5] arm64: defconfig: Enable interconnect for imx8mq

[Martin Kepplinger]

Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely
available.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Acked-by: Georgi Djakov <georgi.djakov@linaro.org>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 3ca9d03d5cb3..0095df536f74 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1078,6 +1078,8 @@ CONFIG_SLIM_QCOM_CTRL=m
 CONFIG_SLIM_QCOM_NGD_CTRL=m
 CONFIG_MUX_MMIO=y
 CONFIG_INTERCONNECT=y
+CONFIG_INTERCONNECT_IMX=m
+CONFIG_INTERCONNECT_IMX8MQ=m
 CONFIG_INTERCONNECT_QCOM=y
 CONFIG_INTERCONNECT_QCOM_MSM8916=m
 CONFIG_INTERCONNECT_QCOM_OSM_L3=m
-- 
2.20.1

Re: [PATCH v4 5/5] arm64: defconfig: Enable interconnect for imx8mq

[Shawn Guo]

On Thu, Jan 07, 2021 at 01:17:54PM +0100, Martin Kepplinger wrote:
> Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely
> available.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> Acked-by: Georgi Djakov <georgi.djakov@linaro.org>

Applied, thanks.

Re: [PATCH v4 0/5] imx8mq: updates for the interconnect fabric

[Shawn Guo]

On Thu, Jan 07, 2021 at 01:17:49PM +0100, Martin Kepplinger wrote:
> revision history:
> v4: (thanks Shawn, Georgi and Greg)
>  * reorder to have dt-bindings doc before code addition
>  * add newline between dt nodes
>  * removed "interconnect: imx8mq: Use icc_sync_state" from the patchset
>    since it's part of gregkh/char-misc.git
>  * Add acks
> 
> v3: (thanks Krysztof and Georgi)
>  * drop the defconfig cycling patch and fix the interconnect enable config
>  * add the noc node to imx8mq only
>  * add missing signed-off-by
>  * https://lore.kernel.org/linux-arm-kernel/20201210100906.18205-1-martin.kepplinger@puri.sm/T/#t
> 
> v2: (thanks Lucas)
>  * reorder and clean up defconfig changes
>  * use "dram" for the interconnect path name and document it
>  * https://lore.kernel.org/linux-arm-kernel/20201201123932.12312-1-martin.kepplinger@puri.sm/T/#t
> 
> v1:
>  * https://lore.kernel.org/linux-arm-kernel/20201201100124.4676-1-martin.kepplinger@puri.sm/T/#t
> 
> thanks,
>                         martin
> 
> 
> Leonard Crestez (1):
>   arm64: dts: imx8mq: Add NOC node
> 
> Martin Kepplinger (4):
>   arm64: dts: imx8mq: Add interconnect provider property
>   dt-bindings: mxsfb: Add interconnect bindings for LCDIF path
>   arm64: dts: imx8mq: Add interconnect for lcdif
>   arm64: defconfig: Enable interconnect for imx8mq

I only received 3 patches, 1/5, 4/5 and 5/5.

Shawn

Re: [PATCH v4 0/5] imx8mq: updates for the interconnect fabric

[Martin Kepplinger]

On 11.01.21 05:51, Shawn Guo wrote:
> On Thu, Jan 07, 2021 at 01:17:49PM +0100, Martin Kepplinger wrote:
>> revision history:
>> v4: (thanks Shawn, Georgi and Greg)
>>   * reorder to have dt-bindings doc before code addition
>>   * add newline between dt nodes
>>   * removed "interconnect: imx8mq: Use icc_sync_state" from the patchset
>>     since it's part of gregkh/char-misc.git
>>   * Add acks
>>
>> v3: (thanks Krysztof and Georgi)
>>   * drop the defconfig cycling patch and fix the interconnect enable config
>>   * add the noc node to imx8mq only
>>   * add missing signed-off-by
>>   * https://lore.kernel.org/linux-arm-kernel/20201210100906.18205-1-martin.kepplinger@puri.sm/T/#t
>>
>> v2: (thanks Lucas)
>>   * reorder and clean up defconfig changes
>>   * use "dram" for the interconnect path name and document it
>>   * https://lore.kernel.org/linux-arm-kernel/20201201123932.12312-1-martin.kepplinger@puri.sm/T/#t
>>
>> v1:
>>   * https://lore.kernel.org/linux-arm-kernel/20201201100124.4676-1-martin.kepplinger@puri.sm/T/#t
>>
>> thanks,
>>                          martin
>>
>>
>> Leonard Crestez (1):
>>    arm64: dts: imx8mq: Add NOC node
>>
>> Martin Kepplinger (4):
>>    arm64: dts: imx8mq: Add interconnect provider property
>>    dt-bindings: mxsfb: Add interconnect bindings for LCDIF path
>>    arm64: dts: imx8mq: Add interconnect for lcdif
>>    arm64: defconfig: Enable interconnect for imx8mq
> 
> I only received 3 patches, 1/5, 4/5 and 5/5.
> 
> Shawn
> 

strange as they made it to the lists, see 
https://lore.kernel.org/linux-arm-kernel/20210107121754.3295-1-martin.kepplinger@puri.sm/ 
but I can resend into this thread.

                              martin

[PATCH v4 2/5] arm64: dts: imx8mq: Add interconnect provider property

[Martin Kepplinger]

Add #interconnect-cells on main &noc so that it will probe the interconnect
provider.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Acked-by: Georgi Djakov <georgi.djakov@linaro.org>
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index dbe480a76aa1..89e7de2e7f7a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1163,6 +1163,7 @@
 			reg = <0x32700000 0x100000>;
 			clocks = <&clk IMX8MQ_CLK_NOC>;
 			fsl,ddrc = <&ddrc>;
+			#interconnect-cells = <1>;
 			operating-points-v2 = <&noc_opp_table>;
 
 			noc_opp_table: opp-table {
-- 
2.20.1

Re: [PATCH v4 2/5] arm64: dts: imx8mq: Add interconnect provider property

[Shawn Guo]

On Mon, Jan 11, 2021 at 09:21:44AM +0100, Martin Kepplinger wrote:
> Add #interconnect-cells on main &noc so that it will probe the interconnect
> provider.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> Acked-by: Georgi Djakov <georgi.djakov@linaro.org>

Applied, thanks.

[PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

[Martin Kepplinger]

Add optional interconnect properties for the dram path requests.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
index c985871c46b3..d494a2674290 100644
--- a/Documentation/devicetree/bindings/display/mxsfb.txt
+++ b/Documentation/devicetree/bindings/display/mxsfb.txt
@@ -15,6 +15,12 @@ Required properties:
     - "pix" for the LCDIF block clock
     - (MX6SX-only) "axi", "disp_axi" for the bus interface clock
 
+Optional properties:
+- interconnects : interconnect path specifier for LCDIF according to
+		Documentation/devicetree/bindings/interconnect/interconnect.txt.
+- interconnect-names: the name describing the interconnect path.
+		Should be "dram" for i.MX8MQ.
+
 Required sub-nodes:
   - port: The connection to an encoder chip.
 
-- 
2.20.1

Re: [PATCH v4 3/5] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path

[Rob Herring]

On Mon, Jan 11, 2021 at 09:22:40AM +0100, Martin Kepplinger wrote:
> Add optional interconnect properties for the dram path requests.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++++++
>  1 file changed, 6 insertions(+)

Looks fine, but I believe there's an in flight patch to convert this to 
schema. Please coordinate with that.

> 
> diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt
> index c985871c46b3..d494a2674290 100644
> --- a/Documentation/devicetree/bindings/display/mxsfb.txt
> +++ b/Documentation/devicetree/bindings/display/mxsfb.txt
> @@ -15,6 +15,12 @@ Required properties:
>      - "pix" for the LCDIF block clock
>      - (MX6SX-only) "axi", "disp_axi" for the bus interface clock
>  
> +Optional properties:
> +- interconnects : interconnect path specifier for LCDIF according to
> +		Documentation/devicetree/bindings/interconnect/interconnect.txt.
> +- interconnect-names: the name describing the interconnect path.
> +		Should be "dram" for i.MX8MQ.
> +
>  Required sub-nodes:
>    - port: The connection to an encoder chip.
>  
> -- 
> 2.20.1
>