From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Marcus Cooper <codekipper@gmail.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 02/10] power: supply: ab8500: Push data to power supply code
Date: Thu, 28 Jan 2021 08:12:32 +0000 [thread overview]
Message-ID: <20210128081232.GA4774@dell> (raw)
In-Reply-To: <20210123221908.2993388-3-linus.walleij@linaro.org>
On Sat, 23 Jan 2021, Linus Walleij wrote:
> The global definition of platform data for the battery
> management code has no utility after the OF conversion,
> move the <linux/mfd/abx500/ab8500-bm.h> to be a local
> file in drivers/power/supply and stop defining the
> platform data in drivers/power/supply/ab8500_bmdata.c
> and broadcast to the kernel only to have it assigned
> as platform data to the MFD cells and then picked back
> into the same subsystem that defined it in the first
> place. This kills off a layer of indirection.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/mfd/ab8500-core.c | 17 +++++----
> .../power/supply}/ab8500-bm.h | 19 ++--------
> drivers/power/supply/ab8500_bmdata.c | 3 +-
> drivers/power/supply/ab8500_btemp.c | 35 +++----------------
> drivers/power/supply/ab8500_charger.c | 10 ++----
> drivers/power/supply/ab8500_fg.c | 10 ++----
> drivers/power/supply/abx500_chargalg.c | 10 ++----
> drivers/power/supply/pm2301_charger.c | 2 +-
> 8 files changed, 27 insertions(+), 79 deletions(-)
> rename {include/linux/mfd/abx500 => drivers/power/supply}/ab8500-bm.h (96%)
>
> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
> index ba8da061af0e..82db43b2b6f1 100644
> --- a/drivers/mfd/ab8500-core.c
> +++ b/drivers/mfd/ab8500-core.c
> @@ -19,7 +19,6 @@
> #include <linux/mfd/core.h>
> #include <linux/mfd/abx500.h>
> #include <linux/mfd/abx500/ab8500.h>
> -#include <linux/mfd/abx500/ab8500-bm.h>
> #include <linux/mfd/dbx500-prcmu.h>
> #include <linux/regulator/ab8500.h>
> #include <linux/of.h>
> @@ -610,14 +609,14 @@ int ab8500_suspend(struct ab8500 *ab8500)
> }
>
> static const struct mfd_cell ab8500_bm_devs[] = {
> - MFD_CELL_OF("ab8500-charger", NULL, &ab8500_bm_data,
> - sizeof(ab8500_bm_data), 0, "stericsson,ab8500-charger"),
> - MFD_CELL_OF("ab8500-btemp", NULL, &ab8500_bm_data,
> - sizeof(ab8500_bm_data), 0, "stericsson,ab8500-btemp"),
> - MFD_CELL_OF("ab8500-fg", NULL, &ab8500_bm_data,
> - sizeof(ab8500_bm_data), 0, "stericsson,ab8500-fg"),
> - MFD_CELL_OF("ab8500-chargalg", NULL, &ab8500_bm_data,
> - sizeof(ab8500_bm_data), 0, "stericsson,ab8500-chargalg"),
> + MFD_CELL_OF("ab8500-charger", NULL, NULL, 0, 0,
> + "stericsson,ab8500-charger"),
> + MFD_CELL_OF("ab8500-btemp", NULL, NULL, 0, 0,
> + "stericsson,ab8500-btemp"),
> + MFD_CELL_OF("ab8500-fg", NULL, NULL, 0, 0,
> + "stericsson,ab8500-fg"),
> + MFD_CELL_OF("ab8500-chargalg", NULL, NULL, 0, 0,
> + "stericsson,ab8500-chargalg"),
> };
If you rework this, would you mind popping these on one line please?
Other than that:
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-01-28 8:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 22:18 [PATCH 00/10] power: supply: ab8500: refactor and isolate Linus Walleij
2021-01-23 22:18 ` [PATCH 01/10] power: supply: ab8500: Require device tree Linus Walleij
2021-01-23 22:19 ` [PATCH 02/10] power: supply: ab8500: Push data to power supply code Linus Walleij
2021-01-28 8:12 ` Lee Jones [this message]
2021-01-23 22:19 ` [PATCH 03/10] power: supply: ab8500: Push algorithm " Linus Walleij
2021-01-23 22:19 ` [PATCH 04/10] power: supply: ab8500: Push data " Linus Walleij
2021-01-25 8:44 ` Lee Jones
2021-01-23 22:19 ` [PATCH 05/10] power: supply: ab8500: Move to componentized binding Linus Walleij
2021-01-28 0:10 ` Sebastian Reichel
2021-01-23 22:19 ` [PATCH 06/10] power: supply: ab8500: Call battery population once Linus Walleij
2021-01-23 22:19 ` [PATCH 07/10] power: supply: ab8500: Avoid NULL pointers Linus Walleij
2021-01-23 22:19 ` [PATCH 08/10] power: supply: ab8500: Enable USB and AC Linus Walleij
2021-01-23 22:19 ` [PATCH 09/10] power: supply: ab8500: Drop unused member Linus Walleij
2021-01-23 22:19 ` [PATCH 10/10] power: supply: ab8500_bmdata: Use standard phandle Linus Walleij
2021-01-28 0:07 ` Sebastian Reichel
2021-01-28 0:17 ` [PATCH 00/10] power: supply: ab8500: refactor and isolate Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128081232.GA4774@dell \
--to=lee.jones@linaro.org \
--cc=codekipper@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).