From: Yue Hu <zbestahu@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@rjwysocki.net, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, linux-pm@vger.kernel.org, huyue2@yulong.com,
zbestahu@163.com
Subject: Re: [PATCH] cpufreq: schedutil: Correct comment to update_lock of struct sugov_policy
Date: Thu, 18 Feb 2021 17:28:45 +0800 [thread overview]
Message-ID: <20210218172845.000071c1.zbestahu@gmail.com> (raw)
In-Reply-To: <20210218092658.y4dxcxayz25ogrpi@vireshk-i7>
On Thu, 18 Feb 2021 14:56:58 +0530
Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 18-02-21, 17:23, Yue Hu wrote:
> > From: Yue Hu <huyue2@yulong.com>
> >
> > Currently, update_lock is also used in sugov_update_single_freq().
> >
> > Signed-off-by: Yue Hu <huyue2@yulong.com>
> > ---
> > kernel/sched/cpufreq_schedutil.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/cpufreq_schedutil.c
> > b/kernel/sched/cpufreq_schedutil.c index add8081..cc0308c 100644
> > --- a/kernel/sched/cpufreq_schedutil.c
> > +++ b/kernel/sched/cpufreq_schedutil.c
> > @@ -26,7 +26,7 @@ struct sugov_policy {
> > struct sugov_tunables *tunables;
> > struct list_head tunables_hook;
> >
> > - raw_spinlock_t update_lock; /* For
> > shared policies */
> > + raw_spinlock_t update_lock; /* For
> > single + shared policies */
>
> I will just remove the comments, its pretty much useless anyway.
>
ok, i will do it.
Thx.
prev parent reply other threads:[~2021-02-18 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 9:23 [PATCH] cpufreq: schedutil: Correct comment to update_lock of struct sugov_policy Yue Hu
2021-02-18 9:26 ` Viresh Kumar
2021-02-18 9:28 ` Yue Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218172845.000071c1.zbestahu@gmail.com \
--to=zbestahu@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=huyue2@yulong.com \
--cc=juri.lelli@redhat.com \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=zbestahu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).