* [PATCH] cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy
@ 2021-02-18 9:37 Yue Hu
2021-02-18 9:39 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Yue Hu @ 2021-02-18 9:37 UTC (permalink / raw)
To: rjw, viresh.kumar, mingo, peterz, juri.lelli, vincent.guittot
Cc: dietmar.eggemann, rostedt, bsegall, linux-pm, huyue2, zbestahu
From: Yue Hu <huyue2@yulong.com>
Currently, update_lock is also used in sugov_update_single_freq(). The
comment is not helpful anymore.
Signed-off-by: Yue Hu <huyue2@yulong.com>
---
kernel/sched/cpufreq_schedutil.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index add8081..fd43d59 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -26,7 +26,7 @@ struct sugov_policy {
struct sugov_tunables *tunables;
struct list_head tunables_hook;
- raw_spinlock_t update_lock; /* For shared policies */
+ raw_spinlock_t update_lock;
u64 last_freq_update_time;
s64 freq_update_delay_ns;
unsigned int next_freq;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy
2021-02-18 9:37 [PATCH] cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy Yue Hu
@ 2021-02-18 9:39 ` Viresh Kumar
2021-02-18 9:43 ` Yue Hu
2021-02-19 15:15 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: Viresh Kumar @ 2021-02-18 9:39 UTC (permalink / raw)
To: Yue Hu
Cc: rjw, mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, linux-pm, huyue2, zbestahu
Always mention version number and version history in a patch. Don't
resend it now anyway.
On 18-02-21, 17:37, Yue Hu wrote:
> From: Yue Hu <huyue2@yulong.com>
>
> Currently, update_lock is also used in sugov_update_single_freq(). The
> comment is not helpful anymore.
>
> Signed-off-by: Yue Hu <huyue2@yulong.com>
> ---
> kernel/sched/cpufreq_schedutil.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index add8081..fd43d59 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -26,7 +26,7 @@ struct sugov_policy {
> struct sugov_tunables *tunables;
> struct list_head tunables_hook;
>
> - raw_spinlock_t update_lock; /* For shared policies */
> + raw_spinlock_t update_lock;
> u64 last_freq_update_time;
> s64 freq_update_delay_ns;
> unsigned int next_freq;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy
2021-02-18 9:39 ` Viresh Kumar
@ 2021-02-18 9:43 ` Yue Hu
2021-02-19 15:15 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Yue Hu @ 2021-02-18 9:43 UTC (permalink / raw)
To: Viresh Kumar
Cc: rjw, mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, linux-pm, huyue2, zbestahu
On Thu, 18 Feb 2021 15:09:24 +0530
Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Always mention version number and version history in a patch. Don't
> resend it now anyway.
ok, got it.
Thank you.
>
> On 18-02-21, 17:37, Yue Hu wrote:
> > From: Yue Hu <huyue2@yulong.com>
> >
> > Currently, update_lock is also used in sugov_update_single_freq().
> > The comment is not helpful anymore.
> >
> > Signed-off-by: Yue Hu <huyue2@yulong.com>
> > ---
> > kernel/sched/cpufreq_schedutil.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/cpufreq_schedutil.c
> > b/kernel/sched/cpufreq_schedutil.c index add8081..fd43d59 100644
> > --- a/kernel/sched/cpufreq_schedutil.c
> > +++ b/kernel/sched/cpufreq_schedutil.c
> > @@ -26,7 +26,7 @@ struct sugov_policy {
> > struct sugov_tunables *tunables;
> > struct list_head tunables_hook;
> >
> > - raw_spinlock_t update_lock; /* For
> > shared policies */
> > + raw_spinlock_t update_lock;
> > u64 last_freq_update_time;
> > s64 freq_update_delay_ns;
> > unsigned int next_freq;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy
2021-02-18 9:39 ` Viresh Kumar
2021-02-18 9:43 ` Yue Hu
@ 2021-02-19 15:15 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2021-02-19 15:15 UTC (permalink / raw)
To: Viresh Kumar, Yue Hu
Cc: Rafael J. Wysocki, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt,
Benjamin Segall, Linux PM, Yue Hu, zbestahu
On Thu, Feb 18, 2021 at 11:51 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> Always mention version number and version history in a patch. Don't
> resend it now anyway.
>
> On 18-02-21, 17:37, Yue Hu wrote:
> > From: Yue Hu <huyue2@yulong.com>
> >
> > Currently, update_lock is also used in sugov_update_single_freq(). The
> > comment is not helpful anymore.
> >
> > Signed-off-by: Yue Hu <huyue2@yulong.com>
> > ---
> > kernel/sched/cpufreq_schedutil.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> > index add8081..fd43d59 100644
> > --- a/kernel/sched/cpufreq_schedutil.c
> > +++ b/kernel/sched/cpufreq_schedutil.c
> > @@ -26,7 +26,7 @@ struct sugov_policy {
> > struct sugov_tunables *tunables;
> > struct list_head tunables_hook;
> >
> > - raw_spinlock_t update_lock; /* For shared policies */
> > + raw_spinlock_t update_lock;
> > u64 last_freq_update_time;
> > s64 freq_update_delay_ns;
> > unsigned int next_freq;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied as 5.12-rc material, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-19 15:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-18 9:37 [PATCH] cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy Yue Hu
2021-02-18 9:39 ` Viresh Kumar
2021-02-18 9:43 ` Yue Hu
2021-02-19 15:15 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).