From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 643E3C433DB for ; Sat, 6 Mar 2021 14:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 275C16501B for ; Sat, 6 Mar 2021 14:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230426AbhCFOio (ORCPT ); Sat, 6 Mar 2021 09:38:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:35086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhCFOiR (ORCPT ); Sat, 6 Mar 2021 09:38:17 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9909F64EBD; Sat, 6 Mar 2021 14:38:15 +0000 (UTC) Date: Sat, 6 Mar 2021 14:38:12 +0000 From: Jonathan Cameron To: "Rafael J. Wysocki" Cc: Linux ACPI , LKML , Linux PM , Zhang Rui , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org Subject: Re: [PATCH v1 3/4] IIO: acpi-als: Get rid of ACPICA message printing Message-ID: <20210306143812.4da7b32e@archlinux> In-Reply-To: <6250192.e2TqKytQZN@kreacher> References: <2775419.haJ69vZeI0@kreacher> <6250192.e2TqKytQZN@kreacher> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, 05 Mar 2021 19:42:29 +0100 "Rafael J. Wysocki" wrote: > From: Rafael J. Wysocki > > Use acpi_evaluation_failure_warn() introduced previously instead of > the ACPICA-specific ACPI_EXCEPTION() macro to log warning messages > regarding ACPI object evaluation failures and drop the > ACPI_MODULE_NAME() definition only used by the ACPICA message > printing macro. > > Signed-off-by: Rafael J. Wysocki Acked-by: Jonathan Cameron > --- > drivers/iio/light/acpi-als.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > Index: linux-pm/drivers/iio/light/acpi-als.c > =================================================================== > --- linux-pm.orig/drivers/iio/light/acpi-als.c > +++ linux-pm/drivers/iio/light/acpi-als.c > @@ -26,8 +26,6 @@ > #define ACPI_ALS_DEVICE_NAME "acpi-als" > #define ACPI_ALS_NOTIFY_ILLUMINANCE 0x80 > > -ACPI_MODULE_NAME("acpi-als"); > - > /* > * So far, there's only one channel in here, but the specification for > * ACPI0008 says there can be more to what the block can report. Like > @@ -91,7 +89,7 @@ static int acpi_als_read_value(struct ac > &temp_val); > > if (ACPI_FAILURE(status)) { > - ACPI_EXCEPTION((AE_INFO, status, "Error reading ALS %s", prop)); > + acpi_evaluation_failure_warn(als->device->handle, prop, status); > return -EIO; > } > > > >