Re: [PATCH v2 5/5] powercap/drivers/dtpm: Scale the power with the load

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2629 bytes --]

Hi Daniel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pm/linux-next]
[also build test WARNING on linux/master linus/master v5.12-rc2 next-20210309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Lezcano/powercap-drivers-dtpm-Encapsulate-even-more-the-code/20210310-064505
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: powerpc-randconfig-r005-20210309 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project cd9a69289c7825d54450cb6829fef2c8e0f1963a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc cross compiling tool for clang build
        # apt-get install binutils-powerpc-linux-gnu
        # https://github.com/0day-ci/linux/commit/195420841883f38897ba1e10ff70641dab0191ba
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Lezcano/powercap-drivers-dtpm-Encapsulate-even-more-the-code/20210310-064505
        git checkout 195420841883f38897ba1e10ff70641dab0191ba
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/powercap/dtpm_cpu.c:76:32: warning: variable 'cpu' is uninitialized when used here [-Wuninitialized]
           max = arch_scale_cpu_capacity(cpu);
                                         ^~~
   drivers/powercap/dtpm_cpu.c:74:9: note: initialize the variable 'cpu' to silence this warning
           int cpu;
                  ^
                   = 0
   1 warning generated.


vim +/cpu +76 drivers/powercap/dtpm_cpu.c

    70	
    71	static u64 scale_pd_power_uw(struct cpumask *pd_mask, u64 power)
    72	{
    73		unsigned long max, sum_util = 0;
    74		int cpu;
    75	
  > 76		max = arch_scale_cpu_capacity(cpu);
    77	
    78		for_each_cpu_and(cpu, pd_mask, cpu_online_mask)
    79			sum_util += sched_cpu_util(cpu, max);
    80	
    81		return (power * ((sum_util << 10) / max)) >> 10;
    82	}
    83	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 22230 bytes --]