From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C32C433ED for ; Thu, 15 Apr 2021 02:22:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 389D66115C for ; Thu, 15 Apr 2021 02:22:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbhDOCWa (ORCPT ); Wed, 14 Apr 2021 22:22:30 -0400 Received: from mga05.intel.com ([192.55.52.43]:29039 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229646AbhDOCWa (ORCPT ); Wed, 14 Apr 2021 22:22:30 -0400 IronPort-SDR: /yqU6CHvMnFWvvZIJ9TfUfxya1dmwgKDMLrPIC0Ww9S4mcjs3a1ebIsfqIbQvQvFKKhJddCwac TuFBTjs/bJTg== X-IronPort-AV: E=McAfee;i="6200,9189,9954"; a="280090656" X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="280090656" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 19:22:08 -0700 IronPort-SDR: ggwZsxSbhGyBGUchl9E+OtB9B8VKWhqmkzuPbSU6GF6wDANuPymFEXZzxREtBtSQily6tuFsTU aJQG2fWdlUGw== X-IronPort-AV: E=Sophos;i="5.82,223,1613462400"; d="scan'208";a="418570192" Received: from chenyu-desktop.sh.intel.com (HELO chenyu-desktop) ([10.239.158.173]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 19:22:07 -0700 Date: Thu, 15 Apr 2021 10:26:00 +0800 From: Chen Yu To: Calvin Walton Cc: Linux PM list , "linux-kernel@vger.kernel.org" , Len Brown Subject: Re: [PATCH] Fix turbostat exiting with an error when run on AMD CPUs Message-ID: <20210415022600.GA341188@chenyu-desktop> References: <88d11c19e662f67ae492eb4b93e12e1b24e68c1d.camel@kepstin.ca> <07f5e30a2af1674f0a2f8995641bbaaf64e47d34.camel@kepstin.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07f5e30a2af1674f0a2f8995641bbaaf64e47d34.camel@kepstin.ca> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Calvin, On Wed, Apr 14, 2021 at 10:08:07PM -0400, Calvin Walton wrote: > On Wed, 2021-04-14 at 22:05 -0400, Calvin Walton wrote: > > The current version of turbostat exits immediately upon entering the > > main loop, with error code -13. This is a regression that was > > introducted > > in these commits: > > > > 9972d5d84d76 tools/power turbostat: Enable accumulate RAPL display > > 87e15da95775 tools/power turbostat: Introduce functions to accumulate > > RAPL consumption > > Ah, I failed to check the mailing list before sending this patch! Terry > Bowman's fix here should probably be preferred: > https://patchwork.kernel.org/project/linux-pm/patch/20210331155807.3838-1-terry.bowman@amd.com/ > > My patch was simply the minimum necessary to get turbostat working > again. Thanks for reporting this. We had a fix for this previously at https://lkml.org/lkml/2021/3/12/682 I'll check with Len if this patch has been merged. thanks, Chenyu > -- > Calvin Walton >