From: kernel test robot <lkp@intel.com>
To: Ikjoon Jang <ikjn@chromium.org>,
linux-pm@vger.kernel.org, Sebastian Reichel <sre@kernel.org>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Hsinyi Wang <hsinyi@chromium.org>,
Ikjoon Jang <ikjn@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] power: supply: sbs-battery: cache constant string properties
Date: Wed, 26 May 2021 16:59:03 +0800 [thread overview]
Message-ID: <202105261629.VSdIXVAn-lkp@intel.com> (raw)
In-Reply-To: <20210526132509.v3.1.I446881dabe094fff375847593be87ec2624f587f@changeid>
[-- Attachment #1: Type: text/plain, Size: 3481 bytes --]
Hi Ikjoon,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on power-supply/for-next]
[also build test ERROR on v5.13-rc3 next-20210525]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ikjoon-Jang/power-supply-sbs-battery-cache-constant-string-properties/20210526-132701
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: arm-randconfig-r036-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/584859e4c0fe02c3c7b9b4e8c4a2c99d5212fe21
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ikjoon-Jang/power-supply-sbs-battery-cache-constant-string-properties/20210526-132701
git checkout 584859e4c0fe02c3c7b9b4e8c4a2c99d5212fe21
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/power/supply/sbs-battery.c:236:27: warning: using the result of an assignment as a condition without parentheses [-Wparentheses]
if (chip->strings[i][0] = 0;
~~~~~~~~~~~~~~~~~~~~^~~
drivers/power/supply/sbs-battery.c:236:27: note: place parentheses around the assignment to silence this warning
if (chip->strings[i][0] = 0;
^
( )
drivers/power/supply/sbs-battery.c:236:27: note: use '==' to turn this assignment into an equality comparison
if (chip->strings[i][0] = 0;
^
==
>> drivers/power/supply/sbs-battery.c:236:30: error: expected ')'
if (chip->strings[i][0] = 0;
^
drivers/power/supply/sbs-battery.c:236:6: note: to match this '('
if (chip->strings[i][0] = 0;
^
>> drivers/power/supply/sbs-battery.c:236:30: warning: if statement has empty body [-Wempty-body]
if (chip->strings[i][0] = 0;
^
drivers/power/supply/sbs-battery.c:236:30: note: put the semicolon on a separate line to silence this warning
2 warnings and 1 error generated.
vim +236 drivers/power/supply/sbs-battery.c
228
229 static void sbs_invalidate_cached_props(struct sbs_info *chip)
230 {
231 int i = 0;
232
233 chip->technology = -1;
234
235 for (i = 0; i < NR_STRING_BUFFERS; i++)
> 236 if (chip->strings[i][0] = 0;
237 }
238
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34618 bytes --]
prev parent reply other threads:[~2021-05-26 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 5:25 [PATCH v3] power: supply: sbs-battery: cache constant string properties Ikjoon Jang
2021-05-26 8:37 ` kernel test robot
2021-05-26 8:59 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202105261629.VSdIXVAn-lkp@intel.com \
--to=lkp@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=hsinyi@chromium.org \
--cc=ikjn@chromium.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).