From: Paul Fertser <fercerpav@gmail.com>
To: Martin Ashby <martin@ashbysoft.com>
Cc: t.schramm@manjaro.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] power: supply: cw2015: Add CHARGE_NOW support
Date: Fri, 18 Jun 2021 15:30:17 +0300 [thread overview]
Message-ID: <20210618123017.GA10695@home.paul.comp> (raw)
In-Reply-To: <20210218124250.128008-1-martin@ashbysoft.com>
Hello Martin,
On Thu, Feb 18, 2021 at 07:42:50AM -0500, Martin Ashby wrote:
> + case POWER_SUPPLY_PROP_CHARGE_NOW:
> + val->intval = cw_bat->battery.charge_full_design_uah;
> + val->intval = val->intval * cw_bat->soc / 100;
Are you sure the chip reports current state of charge relative to the
full design capacity rather than to the latest auto-calibrated full
capacity? That would mean that over time as the cells wear out
cw_bat->soc (PROP_CAPACITY) is never going to be reaching 100; does
this match your experience?
--
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav@gmail.com
next prev parent reply other threads:[~2021-06-18 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 12:42 [PATCH] power: supply: cw2015: Add CHARGE_NOW support Martin Ashby
2021-02-18 14:53 ` Tobias Schramm
2021-06-18 12:30 ` Paul Fertser [this message]
2021-06-19 9:52 ` Tobias Schramm
2021-06-19 10:21 ` Paul Fertser
2021-06-19 13:48 ` Tobias Schramm
2021-06-19 19:06 ` Paul Fertser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618123017.GA10695@home.paul.comp \
--to=fercerpav@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=martin@ashbysoft.com \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox