From: Adrian Hunter <adrian.hunter@intel.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Saravana Kannan <saravanak@google.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, Avri Altman <avri.altman@wdc.com>,
Bean Huo <huobean@gmail.com>, Can Guo <cang@codeaurora.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Bart Van Assche <bvanassche@acm.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH V3 0/3] driver core: Add ability to delete device links of unregistered devices
Date: Sat, 10 Jul 2021 13:38:16 +0300 [thread overview]
Message-ID: <20210710103819.12532-1-adrian.hunter@intel.com> (raw)
Hi
There is an issue with the SCSI UFS driver when the optional
BOOT well-known LUN fails to probe, which is not a fatal error.
The issue is that the device and its "managed" device link do not
then get deleted. The device because the device link has a
reference to it. The device link because it can only be deleted
by device_del(), but device_add() was never called, so device_del()
never will be either.
Since V2, these patches fix the issue by amending device link removal to
accept removal of a link with an unregistered consumer device, as suggested
by Rafael.
Changes in V3:
driver core: Prevent warning when removing a device link from unregistered consumer
New patch split from "driver core: Add ability to delete device
links of unregistered devices" except first chunk from that patch
dropped as unnecessary
driver core: Add ability to delete device links of unregistered devices
Move warning fix to separate patch.
Changes in V2:
Take approach suggested by Rafael
Adrian Hunter (3):
driver core: Prevent warning when removing a device link from unregistered consumer
driver core: Add ability to delete device links of unregistered devices
scsi: ufshcd: Fix device links when BOOT WLUN fails to probe
drivers/base/core.c | 8 ++++++--
drivers/scsi/ufs/ufshcd.c | 23 +++++++++++++++++++++--
2 files changed, 27 insertions(+), 4 deletions(-)
Regards
Adrian
next reply other threads:[~2021-07-10 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 10:38 Adrian Hunter [this message]
2021-07-10 10:38 ` [PATCH V3 1/3] driver core: Prevent warning when removing a device link from unregistered consumer Adrian Hunter
2021-07-10 15:19 ` Greg Kroah-Hartman
2021-07-14 18:21 ` Rafael J. Wysocki
2021-07-14 18:22 ` Rafael J. Wysocki
2021-07-10 10:38 ` [PATCH V3 2/3] driver core: Add ability to delete device links of unregistered devices Adrian Hunter
2021-07-14 18:26 ` Rafael J. Wysocki
2021-07-10 10:38 ` [PATCH V3 3/3] scsi: ufshcd: Fix device links when BOOT WLUN fails to probe Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210710103819.12532-1-adrian.hunter@intel.com \
--to=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).