From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69134C07E9A for ; Mon, 12 Jul 2021 10:15:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DB79610CB for ; Mon, 12 Jul 2021 10:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232776AbhGLKS3 (ORCPT ); Mon, 12 Jul 2021 06:18:29 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3378 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234050AbhGLKS2 (ORCPT ); Mon, 12 Jul 2021 06:18:28 -0400 Received: from fraeml737-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GNfZV4d0Vz6K5sn; Mon, 12 Jul 2021 18:07:14 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml737-chm.china.huawei.com (10.206.15.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 12 Jul 2021 12:15:37 +0200 Received: from localhost (10.47.25.8) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 12 Jul 2021 11:15:37 +0100 Date: Mon, 12 Jul 2021 11:15:19 +0100 From: Jonathan Cameron To: Andreas Kemnade CC: Jonathan Cameron , , , , , , Subject: Re: [PATCH v2 2/2] power: supply: rn5t618: Add voltage_now property Message-ID: <20210712111519.00000ef7@Huawei.com> In-Reply-To: <20210712091130.2096cf23@aktux> References: <20210705113637.28908-1-andreas@kemnade.info> <20210705113637.28908-3-andreas@kemnade.info> <20210711112039.43c4af7b@jic23-huawei> <20210712091130.2096cf23@aktux> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.25.8] X-ClientProxiedBy: lhreml727-chm.china.huawei.com (10.201.108.78) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, 12 Jul 2021 09:11:30 +0200 Andreas Kemnade wrote: > On Sun, 11 Jul 2021 11:20:39 +0100 > Jonathan Cameron wrote: > > > On Mon, 5 Jul 2021 13:36:37 +0200 > > Andreas Kemnade wrote: > > > > > Read voltage_now via IIO and provide the property. > > > > > > Signed-off-by: Andreas Kemnade > > > Reported-by: kernel test robot > > Huh? Seems unlikely it pointed out that this patch was necessary in general. > > If highlighting a particular fix in an earlier version, then state what it was > > in the commit message. Note for fixes that get rolled into patches, it's > > often just mentioned in the change log and we skip the tag because it can > > cause confusion. > > > The robot found a problem in v1 (missing depends on IIO). It is fixed > now. The message from the bot tells to add a tag. It seems not to make > sense. But probably the bot is also running on public branches (which > will not be rebase) and uses the same message where it actually makes > sense. Yup. It might be helpful if they modified that message to suggest commented format if the fix is rolled into an existing patch. I've seen things like. Reported-by: kernel test robot # Fix something interesting. Which makes it clear what is going on. Jonathan > > I will send a v3 with that tag removed and the other comment addressed. > > Regards, > Andreas