From: kernel test robot <lkp@intel.com>
To: Hans de Goede <hdegoede@redhat.com>, Sebastian Reichel <sre@kernel.org>
Cc: kbuild-all@lists.01.org, Hans de Goede <hdegoede@redhat.com>,
Andrejus Basovas <cpp@gcc.lt>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 08/10] power: supply: axp288_fuel_gauge: Refresh all registers in one go
Date: Fri, 30 Jul 2021 21:39:10 +0800 [thread overview]
Message-ID: <202107302129.q2aOAZSA-lkp@intel.com> (raw)
In-Reply-To: <20210730095607.57541-9-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 4053 bytes --]
Hi Hans,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on power-supply/for-next]
[also build test ERROR on v5.14-rc3 next-20210729]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/power-supply-axp288_fuel_gauge-Reduce-number-of-register-accesses-cleanups/20210730-175716
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: i386-randconfig-a005-20210730 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/1ff192ccce54fdfce899447999a60a195537460c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hans-de-Goede/power-supply-axp288_fuel_gauge-Reduce-number-of-register-accesses-cleanups/20210730-175716
git checkout 1ff192ccce54fdfce899447999a60a195537460c
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/power/supply/axp288_fuel_gauge.c: In function 'fuel_gauge_update_registers':
>> drivers/power/supply/axp288_fuel_gauge.c:219:8: error: implicit declaration of function 'iosf_mbi_block_punit_i2c_access' [-Werror=implicit-function-declaration]
219 | ret = iosf_mbi_block_punit_i2c_access();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/power/supply/axp288_fuel_gauge.c:268:2: error: implicit declaration of function 'iosf_mbi_unblock_punit_i2c_access' [-Werror=implicit-function-declaration]
268 | iosf_mbi_unblock_punit_i2c_access();
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/iosf_mbi_block_punit_i2c_access +219 drivers/power/supply/axp288_fuel_gauge.c
209
210 static int fuel_gauge_update_registers(struct axp288_fg_info *info)
211 {
212 int ret;
213
214 if (info->valid && time_before(jiffies, info->last_updated + AXP288_REG_UPDATE_INTERVAL))
215 return 0;
216
217 dev_dbg(info->dev, "Fuel Gauge updating register values...\n");
218
> 219 ret = iosf_mbi_block_punit_i2c_access();
220 if (ret < 0)
221 return ret;
222
223 ret = fuel_gauge_reg_readb(info, AXP20X_PWR_INPUT_STATUS);
224 if (ret < 0)
225 goto out;
226 info->pwr_stat = ret;
227
228 ret = fuel_gauge_reg_readb(info, AXP20X_FG_RES);
229 if (ret < 0)
230 goto out;
231 info->fg_res = ret;
232
233 ret = iio_read_channel_raw(info->iio_channel[BAT_VOLT], &info->bat_volt);
234 if (ret < 0)
235 goto out;
236
237 if (info->pwr_stat & PS_STAT_BAT_CHRG_DIR) {
238 info->d_curr = 0;
239 ret = iio_read_channel_raw(info->iio_channel[BAT_CHRG_CURR], &info->c_curr);
240 if (ret < 0)
241 goto out;
242 } else {
243 info->c_curr = 0;
244 ret = iio_read_channel_raw(info->iio_channel[BAT_D_CURR], &info->d_curr);
245 if (ret < 0)
246 goto out;
247 }
248
249 ret = fuel_gauge_read_12bit_word(info, AXP288_FG_OCVH_REG);
250 if (ret < 0)
251 goto out;
252 info->ocv = ret;
253
254 ret = fuel_gauge_read_15bit_word(info, AXP288_FG_CC_MTR1_REG);
255 if (ret < 0)
256 goto out;
257 info->fg_cc_mtr1 = ret;
258
259 ret = fuel_gauge_read_15bit_word(info, AXP288_FG_DES_CAP1_REG);
260 if (ret < 0)
261 goto out;
262 info->fg_des_cap1 = ret;
263
264 info->last_updated = jiffies;
265 info->valid = 1;
266 ret = 0;
267 out:
> 268 iosf_mbi_unblock_punit_i2c_access();
269 return ret;
270 }
271
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35990 bytes --]
next prev parent reply other threads:[~2021-07-30 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 9:55 [PATCH v2 00/10] power: supply: axp288_fuel_gauge: Reduce number of register accesses + cleanups Hans de Goede
2021-07-30 9:55 ` [PATCH v2 01/10] power: supply: axp288_fuel_gauge: Fix define alignment Hans de Goede
2021-07-30 9:55 ` [PATCH v2 02/10] power: supply: axp288_fuel_gauge: Remove debugfs support Hans de Goede
2021-07-30 9:56 ` [PATCH v2 03/10] power: supply: axp288_fuel_gauge: Silence the chatty IRQ mapping code Hans de Goede
2021-07-30 9:56 ` [PATCH v2 04/10] power: supply: axp288_fuel_gauge: Report register-address on readb / writeb errors Hans de Goede
2021-07-30 9:56 ` [PATCH v2 05/10] power: supply: axp288_fuel_gauge: Drop retry logic from fuel_gauge_reg_readb() Hans de Goede
2021-07-30 9:56 ` [PATCH v2 06/10] power: supply: axp288_fuel_gauge: Store struct device pointer in axp288_fg_info Hans de Goede
2021-07-30 9:56 ` [PATCH v2 07/10] power: supply: axp288_fuel_gauge: Only read PWR_OP_MODE, FG_LOW_CAP_REG regs once Hans de Goede
2021-07-30 9:56 ` [PATCH v2 08/10] power: supply: axp288_fuel_gauge: Refresh all registers in one go Hans de Goede
2021-07-30 13:39 ` kernel test robot [this message]
2021-07-30 16:14 ` kernel test robot
2021-08-01 11:23 ` Hans de Goede
2021-07-30 9:56 ` [PATCH v2 09/10] power: supply: axp288_fuel_gauge: Move the AXP20X_CC_CTRL check together with the other checks Hans de Goede
2021-07-30 9:56 ` [PATCH v2 10/10] power: supply: axp288_fuel_gauge: Take the P-Unit semaphore only once during probe() Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107302129.q2aOAZSA-lkp@intel.com \
--to=lkp@intel.com \
--cc=cpp@gcc.lt \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).