From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 6/6] cpuidle: tegra: Check whether PMC is ready
Date: Sun, 12 Sep 2021 23:29:07 +0300 [thread overview]
Message-ID: <20210912202907.28471-7-digetx@gmail.com> (raw)
In-Reply-To: <20210912202907.28471-1-digetx@gmail.com>
Check whether PMC is ready before proceeding with the cpuidle registration.
This fixes racing with the PMC driver probe order, which results in a
disabled deepest CC6 idling state if cpuidle driver is probed before the
PMC.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/cpuidle/cpuidle-tegra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/cpuidle/cpuidle-tegra.c b/drivers/cpuidle/cpuidle-tegra.c
index 508bd9f23792..9845629aeb6d 100644
--- a/drivers/cpuidle/cpuidle-tegra.c
+++ b/drivers/cpuidle/cpuidle-tegra.c
@@ -337,6 +337,9 @@ static void tegra_cpuidle_setup_tegra114_c7_state(void)
static int tegra_cpuidle_probe(struct platform_device *pdev)
{
+ if (tegra_pmc_get_suspend_mode() == TEGRA_SUSPEND_NOT_READY)
+ return -EPROBE_DEFER;
+
/* LP2 could be disabled in device-tree */
if (tegra_pmc_get_suspend_mode() < TEGRA_SUSPEND_LP2)
tegra_cpuidle_disable_state(TEGRA_CC6);
--
2.32.0
prev parent reply other threads:[~2021-09-12 20:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 20:29 [PATCH v1 0/6] Tegra cpuidle driver fixes and improvements for 5.16 Dmitry Osipenko
2021-09-12 20:29 ` [PATCH v1 1/6] soc/tegra: fuse: Add stubs needed for compile testing Dmitry Osipenko
2021-09-12 20:29 ` [PATCH v1 2/6] soc/tegra: irq: " Dmitry Osipenko
2021-09-12 20:29 ` [PATCH v1 3/6] soc/tegra: pm: Make stubs usable " Dmitry Osipenko
2021-09-12 20:29 ` [PATCH v1 4/6] clk: tegra: Add stubs needed " Dmitry Osipenko
2021-10-04 19:33 ` Thierry Reding
2021-10-04 20:02 ` Thierry Reding
2021-10-04 20:41 ` Dmitry Osipenko
2021-09-12 20:29 ` [PATCH v1 5/6] cpuidle: tegra: Enable " Dmitry Osipenko
2021-09-27 16:33 ` Dmitry Osipenko
2021-09-29 10:32 ` Daniel Lezcano
2021-09-12 20:29 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210912202907.28471-7-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).