From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD3FC433EF for ; Tue, 19 Oct 2021 10:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D8F660FD8 for ; Tue, 19 Oct 2021 10:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234914AbhJSKhs (ORCPT ); Tue, 19 Oct 2021 06:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230123AbhJSKhr (ORCPT ); Tue, 19 Oct 2021 06:37:47 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 216BEC06161C for ; Tue, 19 Oct 2021 03:35:35 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcmSt-0004vM-Dr; Tue, 19 Oct 2021 12:35:27 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mcmSr-0007we-QY; Tue, 19 Oct 2021 12:35:25 +0200 Date: Tue, 19 Oct 2021 12:35:25 +0200 From: Oleksij Rempel To: Petr Benes Cc: Daniel Lezcano , Michal =?utf-8?B?Vm9rw6HEjQ==?= , Andrzej Pietrasiewicz , linux-pm@vger.kernel.org, Shawn Guo , Amit Kucheria , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Petr =?utf-8?B?QmVuZcWh?= , stable@vger.kernel.org Subject: Re: [PATCH] thermal: imx: Fix temperature measurements on i.MX6 after alarm Message-ID: <20211019103525.GB16320@pengutronix.de> References: <20211008081137.1948848-1-michal.vokac@ysoft.com> <20211018112820.qkebjt2gk2w53lp5@pengutronix.de> <37bc3702-bc98-dc54-e9c7-bf9bc92432f0@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:31:56 up 243 days, 13:55, 126 users, load average: 0.16, 0.21, 0.22 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Petr, On Tue, Oct 19, 2021 at 09:24:44AM +0200, Petr Benes wrote: > On Mon, 18 Oct 2021 at 13:38, Daniel Lezcano wrote: > > > > On 18/10/2021 13:28, Oleksij Rempel wrote: > > > Hi Michal, > > > > > > I hope you have seen this patch: > > > https://lore.kernel.org/all/20210924115032.29684-1-o.rempel@pengutronix.de/ > > > > > > Are there any reason why this was ignored? > > > > No reasons, I was waiting for some tags before merging it. But I forget > > about it when reviewing the current patch. > > Tested Oleksij's patch. It works OK. A question arose. Does it require > CONFIG_PM=y? > If this condition is mandatory and the requirement is valid, Kconfig > should be changed accordingly. > I'm not able to verify it works without PM, seems it doesn't. If CONFIG_PM=n, all pm_runtime_* will do nothing and the imx_thermal core will stay enabled, see: +/* the core was configured and enabled just before */ +pm_runtime_set_active(&pdev->dev); +pm_runtime_enable(data->dev); Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |