From: kernel test robot <lkp@intel.com>
To: Thomas Marangoni <thomas.marangoni@mec.at>,
sre@kernel.org, wens@csie.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Thomas Marangoni <thomas.marangoni@mec.at>
Subject: [RFC PATCH] PM: axp20x_ocv_values_uV[] can be static
Date: Mon, 8 Nov 2021 13:21:41 +0800 [thread overview]
Message-ID: <20211108052141.GA10523@9d7d69d1eba2> (raw)
In-Reply-To: <20211025144455.16665-1-thomas.marangoni@mec.at>
drivers/power/supply/axp20x_battery.c:105:11: warning: symbol 'axp20x_ocv_values_uV' was not declared. Should it be static?
drivers/power/supply/axp20x_battery.c:1004:1: warning: symbol 'dev_attr_voltage_low_alert_level1' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
axp20x_battery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/supply/axp20x_battery.c b/drivers/power/supply/axp20x_battery.c
index 5997c8192c73e..ec17841d51733 100644
--- a/drivers/power/supply/axp20x_battery.c
+++ b/drivers/power/supply/axp20x_battery.c
@@ -102,7 +102,7 @@ struct axp20x_batt_ps {
* OCV curve has fixed values and percentage can be adjusted, this array represents
* the fixed values in uV
*/
-const int axp20x_ocv_values_uV[AXP20X_OCV_MAX + 1] = {
+static const int axp20x_ocv_values_uV[AXP20X_OCV_MAX + 1] = {
3132800,
3273600,
3414400,
@@ -1001,7 +1001,7 @@ static ssize_t voltage_low_alert_level1_store(struct device *dev,
return count;
}
-DEVICE_ATTR_RW(voltage_low_alert_level1);
+static DEVICE_ATTR_RW(voltage_low_alert_level1);
static ssize_t voltage_low_alert_level2_show(struct device *dev,
struct device_attribute *attr,
prev parent reply other threads:[~2021-11-08 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 14:44 [PATCH] PM: Added functionality to the axp20x_battery driver Thomas Marangoni
2021-10-25 22:40 ` Sebastian Reichel
2021-10-27 7:40 ` Thomas Marangoni
2021-11-08 5:21 ` kernel test robot
2021-11-08 5:21 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211108052141.GA10523@9d7d69d1eba2 \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=thomas.marangoni@mec.at \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox