Re: [PATCH] pci: Don't call resume callback for nearly bound devices

Bjorn Helgaas
2021-11-11T18:09:20Z

On Thu, Nov 11, 2021 at 06:32:28PM +0100, Robert Święcki wrote:
> Hi,
>
> > > Thank you very much for testing this. The patch changed the way we
> > > use runtime PM, and the dmesg snippets below look like they could be
> > > related to runtime PM issues.
> > >
> > > I think the conclusion is that we need to revert these commits:
> > >
> > > b5f9c644eb1b ("PCI: Remove struct pci_dev->driver")
> > > 2a4d9408c9e8 ("PCI: Use to_pci_driver() instead of pci_dev->driver")
> > >
> > > from Linus' tree. I queued up those reverts on
> > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=for-linus
> >
> > These reverts appeared in the Nov 11 linux-next tree. Any chance you
> > could verify that they solve the i2c_dw_pci_resume() issue? If it's
> > easier, you can apply them from:
> > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=for-linus
> > instead.
>
> Looks good with the most recent 3 commits from for-linus applied on
> the top of the current linus' tree.
>
> No problematic dmesg entries, my Win11/vfio/kvm/qemu boots fine.

Thank you so much for testing this! I'll ask Linus to pull the two
reverts related to the i2c_dw_pci_resume() issue. Marc and Christian
are still hoping for a fix instead of the third revert.

Bjorn