Re: [PATCH v2 19/20] extcon: intel-cht-wc: Add support for registering a power_supply class-device

Andy Shevchenko
2021-11-16T15:19:52Z

On Sun, Nov 14, 2021 at 7:05 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The bq25890 used on the Yogabook YB1-X90 / -X91 models relies on
> the extcon-driver's BC-1.2 charger detection, and the bq25890 driver
> expect this info to be available through a parent power_supply
> class-device which models the detected charger (idem to how the Type-C
> TCPM code registers a power_supply classdev for the connected charger).
>
> Add support for registering the power_supply class-device expected
> by this setup.

...

> + struct cht_wc_extcon_data *ext = power_supply_get_drvdata(psy);

> + int ret = 0;

Not needed.

> + switch (psp) {
> + case POWER_SUPPLY_PROP_USB_TYPE:
> + val->intval = ext->usb_type;
> + break;
> + case POWER_SUPPLY_PROP_ONLINE:
> + val->intval = ext->usb_type ? 1 : 0;
> + break;
> + default:

> + ret = -EINVAL;
> + break;

return -EINVAL;

> + }
> +
> + return ret;

return 0;

> +}

P.S. And here you have a "break", which is nice!

--
With Best Regards,
Andy Shevchenko