From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4269EC433F5 for ; Mon, 24 Jan 2022 10:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235874AbiAXKlx (ORCPT ); Mon, 24 Jan 2022 05:41:53 -0500 Received: from foss.arm.com ([217.140.110.172]:57228 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231843AbiAXKlx (ORCPT ); Mon, 24 Jan 2022 05:41:53 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CDE606D; Mon, 24 Jan 2022 02:41:52 -0800 (PST) Received: from bogus (unknown [10.57.34.236]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E97D3F73B; Mon, 24 Jan 2022 02:41:48 -0800 (PST) Date: Mon, 24 Jan 2022 10:41:13 +0000 From: Sudeep Holla To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Sudeep Holla , Peter Zijlstra , David Laight , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , "Rafael J. Wysocki" , Viresh Kumar , Cristian Marussi , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 16/54] cpufreq: replace cpumask_weight with cpumask_empty where appropriate Message-ID: <20220124104113.ccbcyipd5gtweulz@bogus> References: <20220123183925.1052919-1-yury.norov@gmail.com> <20220123183925.1052919-17-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220123183925.1052919-17-yury.norov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Jan 23, 2022 at 10:38:47AM -0800, Yury Norov wrote: > drivers/cpufreq calls cpumask_weight() to check if any bit of a given > cpumask is set. We can do it more efficiently with cpumask_empty() because > cpumask_empty() stops traversing the cpumask as soon as it finds first set > bit, while cpumask_weight() counts all bits unconditionally. > Reviewed-by: Sudeep Holla (for SCMI cpufreq driver) -- Regards, Sudeep