From: Pavel Machek <pavel@ucw.cz>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: rafael@kernel.org, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] block: Fix non-kernel-doc comment
Date: Wed, 2 Mar 2022 08:20:48 +0100 [thread overview]
Message-ID: <20220302072047.GA32222@amd> (raw)
In-Reply-To: <20220214091522.100669-1-jiapeng.chong@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 679 bytes --]
Hi!
> Fixes the following W=1 kernel build warning:
>
> kernel/power/swap.c:120: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst.
> +++ b/kernel/power/swap.c
> @@ -170,7 +170,7 @@ static int swsusp_extents_insert(unsigned long swap_offset)
> return 0;
> }
>
> -/**
> +/*
> * alloc_swapdev_block - allocate a swap page and register that it has
> * been allocated, so that it can be freed in case of an error.
> */
The ones before look ok, but this and next one perhaps should be
converted to kerneldoc?
BR,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2022-03-02 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 9:15 [PATCH] block: Fix non-kernel-doc comment Jiapeng Chong
2022-02-14 17:14 ` Randy Dunlap
2022-03-02 7:20 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302072047.GA32222@amd \
--to=pavel@ucw.cz \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).