From: "Pali Rohár" <pali@kernel.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
Date: Tue, 15 Mar 2022 23:46:45 +0100 [thread overview]
Message-ID: <20220315224645.ytcf7y7awc3q2y6j@pali> (raw)
In-Reply-To: <20220315223700.2961660-1-colin.i.king@gmail.com>
On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> There are several spelling mistakes in comments, function names
> and literal strings. Fix these.
I do not think that there are mistakes.
Please look at page 29 of the official bq24150 datasheet:
https://www.ti.com/lit/ds/symlink/bq24150.pdf
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/power/supply/bq2415x_charger.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
> index 5724001e66b9..b35700071966 100644
> --- a/drivers/power/supply/bq2415x_charger.c
> +++ b/drivers/power/supply/bq2415x_charger.c
> @@ -71,7 +71,7 @@
> #define BQ2415X_BIT_OTG_PL 1
> #define BQ2415X_BIT_OTG_EN 0
>
> -/* vender register */
> +/* vendor register */
> #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7))
> #define BQ2415X_SHIFT_VENDER 5
> #define BQ2415X_MASK_PN (BIT(3)|BIT(4))
> @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
> return -1;
> }
>
> -/* return chip vender code */
> -static int bq2415x_get_vender_code(struct bq2415x_device *bq)
> +/* return chip vendor code */
> +static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
> {
> int ret;
>
> @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
> sprintf(revstr, "1.%d", ret);
>
> bq->model = kasprintf(GFP_KERNEL,
> - "chip %s, revision %s, vender code %.3d",
> + "chip %s, revision %s, vendor code %.3d",
> bq2415x_chip_name[chip], revstr,
> - bq2415x_get_vender_code(bq));
> + bq2415x_get_vendor_code(bq));
> if (!bq->model) {
> dev_err(bq->dev, "failed to allocate model name\n");
> return -ENOMEM;
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-03-15 22:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 22:37 [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor" Colin Ian King
2022-03-15 22:46 ` Pali Rohár [this message]
2022-03-15 23:00 ` Colin King (gmail)
2022-03-15 23:07 ` Pali Rohár
2022-03-15 23:09 ` Colin King (gmail)
2022-03-15 23:28 ` Pali Rohár
2022-03-17 11:04 ` Dan Carpenter
2022-03-16 10:35 ` Dan Carpenter
2022-03-16 10:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220315224645.ytcf7y7awc3q2y6j@pali \
--to=pali@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox