* [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
@ 2022-03-15 22:37 Colin Ian King
2022-03-15 22:46 ` Pali Rohár
0 siblings, 1 reply; 9+ messages in thread
From: Colin Ian King @ 2022-03-15 22:37 UTC (permalink / raw)
To: Pali Rohár, Sebastian Reichel, linux-pm
Cc: kernel-janitors, linux-kernel
There are several spelling mistakes in comments, function names
and literal strings. Fix these.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/power/supply/bq2415x_charger.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
index 5724001e66b9..b35700071966 100644
--- a/drivers/power/supply/bq2415x_charger.c
+++ b/drivers/power/supply/bq2415x_charger.c
@@ -71,7 +71,7 @@
#define BQ2415X_BIT_OTG_PL 1
#define BQ2415X_BIT_OTG_EN 0
-/* vender register */
+/* vendor register */
#define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7))
#define BQ2415X_SHIFT_VENDER 5
#define BQ2415X_MASK_PN (BIT(3)|BIT(4))
@@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
return -1;
}
-/* return chip vender code */
-static int bq2415x_get_vender_code(struct bq2415x_device *bq)
+/* return chip vendor code */
+static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
{
int ret;
@@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
sprintf(revstr, "1.%d", ret);
bq->model = kasprintf(GFP_KERNEL,
- "chip %s, revision %s, vender code %.3d",
+ "chip %s, revision %s, vendor code %.3d",
bq2415x_chip_name[chip], revstr,
- bq2415x_get_vender_code(bq));
+ bq2415x_get_vendor_code(bq));
if (!bq->model) {
dev_err(bq->dev, "failed to allocate model name\n");
return -ENOMEM;
--
2.35.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
2022-03-15 22:37 [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor" Colin Ian King
@ 2022-03-15 22:46 ` Pali Rohár
2022-03-15 23:00 ` Colin King (gmail)
2022-03-16 10:35 ` Dan Carpenter
0 siblings, 2 replies; 9+ messages in thread
From: Pali Rohár @ 2022-03-15 22:46 UTC (permalink / raw)
To: Colin Ian King; +Cc: Sebastian Reichel, linux-pm, kernel-janitors, linux-kernel
On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> There are several spelling mistakes in comments, function names
> and literal strings. Fix these.
I do not think that there are mistakes.
Please look at page 29 of the official bq24150 datasheet:
https://www.ti.com/lit/ds/symlink/bq24150.pdf
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/power/supply/bq2415x_charger.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
> index 5724001e66b9..b35700071966 100644
> --- a/drivers/power/supply/bq2415x_charger.c
> +++ b/drivers/power/supply/bq2415x_charger.c
> @@ -71,7 +71,7 @@
> #define BQ2415X_BIT_OTG_PL 1
> #define BQ2415X_BIT_OTG_EN 0
>
> -/* vender register */
> +/* vendor register */
> #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7))
> #define BQ2415X_SHIFT_VENDER 5
> #define BQ2415X_MASK_PN (BIT(3)|BIT(4))
> @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
> return -1;
> }
>
> -/* return chip vender code */
> -static int bq2415x_get_vender_code(struct bq2415x_device *bq)
> +/* return chip vendor code */
> +static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
> {
> int ret;
>
> @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
> sprintf(revstr, "1.%d", ret);
>
> bq->model = kasprintf(GFP_KERNEL,
> - "chip %s, revision %s, vender code %.3d",
> + "chip %s, revision %s, vendor code %.3d",
> bq2415x_chip_name[chip], revstr,
> - bq2415x_get_vender_code(bq));
> + bq2415x_get_vendor_code(bq));
> if (!bq->model) {
> dev_err(bq->dev, "failed to allocate model name\n");
> return -ENOMEM;
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
2022-03-15 22:46 ` Pali Rohár
@ 2022-03-15 23:00 ` Colin King (gmail)
2022-03-15 23:07 ` Pali Rohár
2022-03-16 10:35 ` Dan Carpenter
1 sibling, 1 reply; 9+ messages in thread
From: Colin King (gmail) @ 2022-03-15 23:00 UTC (permalink / raw)
To: Pali Rohár
Cc: Sebastian Reichel, linux-pm, kernel-janitors, linux-kernel
On 15/03/2022 22:46, Pali Rohár wrote:
> On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
>> There are several spelling mistakes in comments, function names
>> and literal strings. Fix these.
>
> I do not think that there are mistakes.
>
> Please look at page 29 of the official bq24150 datasheet:
> https://www.ti.com/lit/ds/symlink/bq24150.pdf
Looks like TI are redefining the spelling in the language :-)
>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>> drivers/power/supply/bq2415x_charger.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
>> index 5724001e66b9..b35700071966 100644
>> --- a/drivers/power/supply/bq2415x_charger.c
>> +++ b/drivers/power/supply/bq2415x_charger.c
>> @@ -71,7 +71,7 @@
>> #define BQ2415X_BIT_OTG_PL 1
>> #define BQ2415X_BIT_OTG_EN 0
>>
>> -/* vender register */
>> +/* vendor register */
>> #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7))
>> #define BQ2415X_SHIFT_VENDER 5
>> #define BQ2415X_MASK_PN (BIT(3)|BIT(4))
>> @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
>> return -1;
>> }
>>
>> -/* return chip vender code */
>> -static int bq2415x_get_vender_code(struct bq2415x_device *bq)
>> +/* return chip vendor code */
>> +static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
>> {
>> int ret;
>>
>> @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
>> sprintf(revstr, "1.%d", ret);
>>
>> bq->model = kasprintf(GFP_KERNEL,
>> - "chip %s, revision %s, vender code %.3d",
>> + "chip %s, revision %s, vendor code %.3d",
>> bq2415x_chip_name[chip], revstr,
>> - bq2415x_get_vender_code(bq));
>> + bq2415x_get_vendor_code(bq));
>> if (!bq->model) {
>> dev_err(bq->dev, "failed to allocate model name\n");
>> return -ENOMEM;
>> --
>> 2.35.1
>>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
2022-03-15 23:00 ` Colin King (gmail)
@ 2022-03-15 23:07 ` Pali Rohár
2022-03-15 23:09 ` Colin King (gmail)
0 siblings, 1 reply; 9+ messages in thread
From: Pali Rohár @ 2022-03-15 23:07 UTC (permalink / raw)
To: Colin King (gmail)
Cc: Sebastian Reichel, linux-pm, kernel-janitors, linux-kernel
On Tuesday 15 March 2022 23:00:14 Colin King (gmail) wrote:
> On 15/03/2022 22:46, Pali Rohár wrote:
> > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> > > There are several spelling mistakes in comments, function names
> > > and literal strings. Fix these.
> >
> > I do not think that there are mistakes.
> >
> > Please look at page 29 of the official bq24150 datasheet:
> > https://www.ti.com/lit/ds/symlink/bq24150.pdf
>
> Looks like TI are redefining the spelling in the language :-)
Well, that could be truth, or maybe it just means something different.
It is about 10 years ago and I do not remember more details about it.
Anyway, in any case register name is vender and kernel code should match
official register naming for which driver was written...
> >
> > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > > ---
> > > drivers/power/supply/bq2415x_charger.c | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
> > > index 5724001e66b9..b35700071966 100644
> > > --- a/drivers/power/supply/bq2415x_charger.c
> > > +++ b/drivers/power/supply/bq2415x_charger.c
> > > @@ -71,7 +71,7 @@
> > > #define BQ2415X_BIT_OTG_PL 1
> > > #define BQ2415X_BIT_OTG_EN 0
> > > -/* vender register */
> > > +/* vendor register */
> > > #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7))
> > > #define BQ2415X_SHIFT_VENDER 5
> > > #define BQ2415X_MASK_PN (BIT(3)|BIT(4))
> > > @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
> > > return -1;
> > > }
> > > -/* return chip vender code */
> > > -static int bq2415x_get_vender_code(struct bq2415x_device *bq)
> > > +/* return chip vendor code */
> > > +static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
> > > {
> > > int ret;
> > > @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
> > > sprintf(revstr, "1.%d", ret);
> > > bq->model = kasprintf(GFP_KERNEL,
> > > - "chip %s, revision %s, vender code %.3d",
> > > + "chip %s, revision %s, vendor code %.3d",
> > > bq2415x_chip_name[chip], revstr,
> > > - bq2415x_get_vender_code(bq));
> > > + bq2415x_get_vendor_code(bq));
> > > if (!bq->model) {
> > > dev_err(bq->dev, "failed to allocate model name\n");
> > > return -ENOMEM;
> > > --
> > > 2.35.1
> > >
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
2022-03-15 23:07 ` Pali Rohár
@ 2022-03-15 23:09 ` Colin King (gmail)
2022-03-15 23:28 ` Pali Rohár
0 siblings, 1 reply; 9+ messages in thread
From: Colin King (gmail) @ 2022-03-15 23:09 UTC (permalink / raw)
To: Pali Rohár
Cc: Sebastian Reichel, linux-pm, kernel-janitors, linux-kernel
On 15/03/2022 23:07, Pali Rohár wrote:
> On Tuesday 15 March 2022 23:00:14 Colin King (gmail) wrote:
>> On 15/03/2022 22:46, Pali Rohár wrote:
>>> On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
>>>> There are several spelling mistakes in comments, function names
>>>> and literal strings. Fix these.
>>>
>>> I do not think that there are mistakes.
>>>
>>> Please look at page 29 of the official bq24150 datasheet:
>>> https://www.ti.com/lit/ds/symlink/bq24150.pdf
>>
>> Looks like TI are redefining the spelling in the language :-)
>
> Well, that could be truth, or maybe it just means something different.
> It is about 10 years ago and I do not remember more details about it.
> Anyway, in any case register name is vender and kernel code should match
> official register naming for which driver was written...
I'm fine with that. Apologies for the noise.
>
>>>
>>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>>> ---
>>>> drivers/power/supply/bq2415x_charger.c | 10 +++++-----
>>>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
>>>> index 5724001e66b9..b35700071966 100644
>>>> --- a/drivers/power/supply/bq2415x_charger.c
>>>> +++ b/drivers/power/supply/bq2415x_charger.c
>>>> @@ -71,7 +71,7 @@
>>>> #define BQ2415X_BIT_OTG_PL 1
>>>> #define BQ2415X_BIT_OTG_EN 0
>>>> -/* vender register */
>>>> +/* vendor register */
>>>> #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7))
>>>> #define BQ2415X_SHIFT_VENDER 5
>>>> #define BQ2415X_MASK_PN (BIT(3)|BIT(4))
>>>> @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
>>>> return -1;
>>>> }
>>>> -/* return chip vender code */
>>>> -static int bq2415x_get_vender_code(struct bq2415x_device *bq)
>>>> +/* return chip vendor code */
>>>> +static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
>>>> {
>>>> int ret;
>>>> @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
>>>> sprintf(revstr, "1.%d", ret);
>>>> bq->model = kasprintf(GFP_KERNEL,
>>>> - "chip %s, revision %s, vender code %.3d",
>>>> + "chip %s, revision %s, vendor code %.3d",
>>>> bq2415x_chip_name[chip], revstr,
>>>> - bq2415x_get_vender_code(bq));
>>>> + bq2415x_get_vendor_code(bq));
>>>> if (!bq->model) {
>>>> dev_err(bq->dev, "failed to allocate model name\n");
>>>> return -ENOMEM;
>>>> --
>>>> 2.35.1
>>>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
2022-03-15 23:09 ` Colin King (gmail)
@ 2022-03-15 23:28 ` Pali Rohár
2022-03-17 11:04 ` Dan Carpenter
0 siblings, 1 reply; 9+ messages in thread
From: Pali Rohár @ 2022-03-15 23:28 UTC (permalink / raw)
To: Colin King (gmail)
Cc: Sebastian Reichel, linux-pm, kernel-janitors, linux-kernel
On Tuesday 15 March 2022 23:09:17 Colin King (gmail) wrote:
> On 15/03/2022 23:07, Pali Rohár wrote:
> > On Tuesday 15 March 2022 23:00:14 Colin King (gmail) wrote:
> > > On 15/03/2022 22:46, Pali Rohár wrote:
> > > > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> > > > > There are several spelling mistakes in comments, function names
> > > > > and literal strings. Fix these.
> > > >
> > > > I do not think that there are mistakes.
> > > >
> > > > Please look at page 29 of the official bq24150 datasheet:
> > > > https://www.ti.com/lit/ds/symlink/bq24150.pdf
> > >
> > > Looks like TI are redefining the spelling in the language :-)
> >
> > Well, that could be truth, or maybe it just means something different.
> > It is about 10 years ago and I do not remember more details about it.
> > Anyway, in any case register name is vender and kernel code should match
> > official register naming for which driver was written...
>
> I'm fine with that. Apologies for the noise.
I looked into dictionaries and word vender exists in Cambridge Dictionary:
https://dictionary.cambridge.org/dictionary/english/vender
Also some details about this word are available in Wiktionary:
https://en.wiktionary.org/wiki/vender#English
And looking at more internet resources and discussions, it looks like
that word vender is just older spelling in American English.
But I really do not know, I'm not native speaker.
> >
> > > >
> > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > > > > ---
> > > > > drivers/power/supply/bq2415x_charger.c | 10 +++++-----
> > > > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > > > >
> > > > > diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
> > > > > index 5724001e66b9..b35700071966 100644
> > > > > --- a/drivers/power/supply/bq2415x_charger.c
> > > > > +++ b/drivers/power/supply/bq2415x_charger.c
> > > > > @@ -71,7 +71,7 @@
> > > > > #define BQ2415X_BIT_OTG_PL 1
> > > > > #define BQ2415X_BIT_OTG_EN 0
> > > > > -/* vender register */
> > > > > +/* vendor register */
> > > > > #define BQ2415X_MASK_VENDER (BIT(5)|BIT(6)|BIT(7))
> > > > > #define BQ2415X_SHIFT_VENDER 5
> > > > > #define BQ2415X_MASK_PN (BIT(3)|BIT(4))
> > > > > @@ -491,8 +491,8 @@ static int bq2415x_detect_revision(struct bq2415x_device *bq)
> > > > > return -1;
> > > > > }
> > > > > -/* return chip vender code */
> > > > > -static int bq2415x_get_vender_code(struct bq2415x_device *bq)
> > > > > +/* return chip vendor code */
> > > > > +static int bq2415x_get_vendor_code(struct bq2415x_device *bq)
> > > > > {
> > > > > int ret;
> > > > > @@ -1501,9 +1501,9 @@ static int bq2415x_power_supply_init(struct bq2415x_device *bq)
> > > > > sprintf(revstr, "1.%d", ret);
> > > > > bq->model = kasprintf(GFP_KERNEL,
> > > > > - "chip %s, revision %s, vender code %.3d",
> > > > > + "chip %s, revision %s, vendor code %.3d",
> > > > > bq2415x_chip_name[chip], revstr,
> > > > > - bq2415x_get_vender_code(bq));
> > > > > + bq2415x_get_vendor_code(bq));
> > > > > if (!bq->model) {
> > > > > dev_err(bq->dev, "failed to allocate model name\n");
> > > > > return -ENOMEM;
> > > > > --
> > > > > 2.35.1
> > > > >
> > >
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
2022-03-15 22:46 ` Pali Rohár
2022-03-15 23:00 ` Colin King (gmail)
@ 2022-03-16 10:35 ` Dan Carpenter
2022-03-16 10:38 ` Dan Carpenter
1 sibling, 1 reply; 9+ messages in thread
From: Dan Carpenter @ 2022-03-16 10:35 UTC (permalink / raw)
To: Pali Rohár
Cc: Colin Ian King, Sebastian Reichel, linux-pm, kernel-janitors,
linux-kernel
On Tue, Mar 15, 2022 at 11:46:45PM +0100, Pali Rohár wrote:
> On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> > There are several spelling mistakes in comments, function names
> > and literal strings. Fix these.
>
> I do not think that there are mistakes.
>
> Please look at page 29 of the official bq24150 datasheet:
> https://www.ti.com/lit/ds/symlink/bq24150.pdf
>
"Table 8. Vender/Part/Revision Register (Read only)"
Just because they spelled it wrong in the hardware spec doesn't mean we
have to spell it wrong here.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
2022-03-16 10:35 ` Dan Carpenter
@ 2022-03-16 10:38 ` Dan Carpenter
0 siblings, 0 replies; 9+ messages in thread
From: Dan Carpenter @ 2022-03-16 10:38 UTC (permalink / raw)
To: Pali Rohár
Cc: Colin Ian King, Sebastian Reichel, linux-pm, kernel-janitors,
linux-kernel
On Wed, Mar 16, 2022 at 01:35:26PM +0300, Dan Carpenter wrote:
> On Tue, Mar 15, 2022 at 11:46:45PM +0100, Pali Rohár wrote:
> > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> > > There are several spelling mistakes in comments, function names
> > > and literal strings. Fix these.
> >
> > I do not think that there are mistakes.
> >
> > Please look at page 29 of the official bq24150 datasheet:
> > https://www.ti.com/lit/ds/symlink/bq24150.pdf
> >
>
> "Table 8. Vender/Part/Revision Register (Read only)"
>
> Just because they spelled it wrong in the hardware spec doesn't mean we
> have to spell it wrong here.
Of course, there are times where spelling mistakes do have to be
preserved forever. I forget the examples. But here I think it's fine
to correct them.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-03-17 11:04 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-15 22:37 [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor" Colin Ian King
2022-03-15 22:46 ` Pali Rohár
2022-03-15 23:00 ` Colin King (gmail)
2022-03-15 23:07 ` Pali Rohár
2022-03-15 23:09 ` Colin King (gmail)
2022-03-15 23:28 ` Pali Rohár
2022-03-17 11:04 ` Dan Carpenter
2022-03-16 10:35 ` Dan Carpenter
2022-03-16 10:38 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).