From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: Colin Ian King <colin.i.king@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor"
Date: Wed, 16 Mar 2022 13:38:34 +0300 [thread overview]
Message-ID: <20220316103834.GE1841@kadam> (raw)
In-Reply-To: <20220316103526.GV3293@kadam>
On Wed, Mar 16, 2022 at 01:35:26PM +0300, Dan Carpenter wrote:
> On Tue, Mar 15, 2022 at 11:46:45PM +0100, Pali Rohár wrote:
> > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> > > There are several spelling mistakes in comments, function names
> > > and literal strings. Fix these.
> >
> > I do not think that there are mistakes.
> >
> > Please look at page 29 of the official bq24150 datasheet:
> > https://www.ti.com/lit/ds/symlink/bq24150.pdf
> >
>
> "Table 8. Vender/Part/Revision Register (Read only)"
>
> Just because they spelled it wrong in the hardware spec doesn't mean we
> have to spell it wrong here.
Of course, there are times where spelling mistakes do have to be
preserved forever. I forget the examples. But here I think it's fine
to correct them.
regards,
dan carpenter
prev parent reply other threads:[~2022-03-16 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 22:37 [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" -> "vendor" Colin Ian King
2022-03-15 22:46 ` Pali Rohár
2022-03-15 23:00 ` Colin King (gmail)
2022-03-15 23:07 ` Pali Rohár
2022-03-15 23:09 ` Colin King (gmail)
2022-03-15 23:28 ` Pali Rohár
2022-03-17 11:04 ` Dan Carpenter
2022-03-16 10:35 ` Dan Carpenter
2022-03-16 10:38 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220316103834.GE1841@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).