linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: rafael@kernel.org
Cc: daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com,
	srinivas.pandruvada@linux.intel.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dave@stgolabs.net
Subject: [PATCH 3/3] thermal: int340x: Cleanup osc context init
Date: Thu, 24 Mar 2022 12:09:50 -0700	[thread overview]
Message-ID: <20220324190950.70486-4-dave@stgolabs.net> (raw)
In-Reply-To: <20220324190950.70486-1-dave@stgolabs.net>

Now that the UUID is already sanitized by the caller,
lets trivially cleanup some of the context arming.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
 drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index e299873d50b8..4c49a6c9d4df 100644
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -169,18 +169,15 @@ static int int3400_thermal_run_osc(acpi_handle handle, char *uuid_str, int *enab
 	acpi_status status;
 	int result = 0;
 	struct acpi_osc_context context = {
-		.uuid_str = NULL,
+		.uuid_str = uuid_str,
 		.rev = 1,
 		.cap.length = 8,
+		.cap.pointer = buf,
 	};
 
-	context.uuid_str = uuid_str;
-
 	buf[OSC_QUERY_DWORD] = 0;
 	buf[OSC_SUPPORT_DWORD] = *enable;
 
-	context.cap.pointer = buf;
-
 	status = acpi_run_osc(handle, &context);
 	if (ACPI_SUCCESS(status)) {
 		ret = *((u32 *)(context.ret.pointer + 4));
-- 
2.26.2


  parent reply	other threads:[~2022-03-24 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-24 19:09 [PATCH 0/3] thermal: int340x: Misc acpi_buffer handling updates Davidlohr Bueso
2022-03-24 19:09 ` [PATCH 1/3] thermal: int340x: Fix bogus acpi_buffer pointer freeing Davidlohr Bueso
2022-03-25 12:25   ` srinivas pandruvada
2022-04-05 18:27   ` Rafael J. Wysocki
2022-03-24 19:09 ` [PATCH 2/3] thermal: int340x: Consolidate freeing of acpi_buffer pointer Davidlohr Bueso
2022-03-24 19:09 ` Davidlohr Bueso [this message]
2022-03-25  2:15 ` [PATCH 0/3] thermal: int340x: Misc acpi_buffer handling updates Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220324190950.70486-4-dave@stgolabs.net \
    --to=dave@stgolabs.net \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).