Linux Power Management development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>
Cc: <linux-pm@vger.kernel.org>, <Sanju.Mehta@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Bjorn Helgaas <helgaas@kernel.org>
Subject: [PATCH v5 2/2] PCI / ACPI: Adjust comment about `HotPlugSupportInD3`
Date: Mon, 28 Mar 2022 15:55:19 -0500	[thread overview]
Message-ID: <20220328205519.250-2-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220328205519.250-1-mario.limonciello@amd.com>

The comments in `acpi_pci_bridge_d3` make an assertion that all devices
behind a PCIe root port that supports D3 also support D3.  This was
pointed out however that it's no guarantee but rather a reasonable
assumption for the ecosystem used for Thunderbolt and USB4.

Update the comment to use weaker language and clarifying this is an
assumption.

Suggested-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v4->v5:
 * New patch

 drivers/pci/pci-acpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 91c165ea4346..4f12d4fca808 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -989,8 +989,8 @@ bool acpi_pci_bridge_d3(struct pci_dev *dev)
 	/*
 	 * The ACPI firmware will provide the device-specific properties through
 	 * _DSD configuration object. Look for the 'HotPlugSupportInD3' property
-	 * for the root port and if it is set we know the hierarchy behind it
-	 * supports D3 just fine.
+	 * for the root port and if it is set we make an assumption that the
+	 * hierarchy behind it supports D3 as well.
 	 */
 	rpdev = pcie_find_root_port(dev);
 	if (!rpdev)
-- 
2.34.1


  reply	other threads:[~2022-03-28 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 20:55 [PATCH v5 1/2] PCI / ACPI: Assume `HotPlugSupportInD3` only if device can wake from D3 Mario Limonciello
2022-03-28 20:55 ` Mario Limonciello [this message]
2022-03-31 19:04 ` Bjorn Helgaas
2022-03-31 19:33   ` Limonciello, Mario
2022-03-31 19:59     ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220328205519.250-2-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Sanju.Mehta@amd.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox