* [PATCH] OPP: call of_node_put() on error path in _bandwidth_supported()
@ 2022-04-06 6:40 Dan Carpenter
2022-04-11 2:50 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-04-06 6:40 UTC (permalink / raw)
To: Viresh Kumar
Cc: Nishanth Menon, Stephen Boyd, Sibi Sankar, linux-pm,
kernel-janitors
This code does not call of_node_put(opp_np) if of_get_next_available_child()
returns NULL. But it should.
Fixes: 45679f9b508f ("opp: Don't parse icc paths unnecessarily")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/opp/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 440ab5a03df9..95b184fc3372 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table)
/* Checking only first OPP is sufficient */
np = of_get_next_available_child(opp_np, NULL);
+ of_node_put(opp_np);
if (!np) {
dev_err(dev, "OPP table empty\n");
return -EINVAL;
}
- of_node_put(opp_np);
prop = of_find_property(np, "opp-peak-kBps", NULL);
of_node_put(np);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OPP: call of_node_put() on error path in _bandwidth_supported()
2022-04-06 6:40 [PATCH] OPP: call of_node_put() on error path in _bandwidth_supported() Dan Carpenter
@ 2022-04-11 2:50 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2022-04-11 2:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, Sibi Sankar, linux-pm,
kernel-janitors
On 06-04-22, 09:40, Dan Carpenter wrote:
> This code does not call of_node_put(opp_np) if of_get_next_available_child()
> returns NULL. But it should.
>
> Fixes: 45679f9b508f ("opp: Don't parse icc paths unnecessarily")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/opp/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 440ab5a03df9..95b184fc3372 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table)
>
> /* Checking only first OPP is sufficient */
> np = of_get_next_available_child(opp_np, NULL);
> + of_node_put(opp_np);
> if (!np) {
> dev_err(dev, "OPP table empty\n");
> return -EINVAL;
> }
> - of_node_put(opp_np);
>
> prop = of_find_property(np, "opp-peak-kBps", NULL);
> of_node_put(np);
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-11 2:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-06 6:40 [PATCH] OPP: call of_node_put() on error path in _bandwidth_supported() Dan Carpenter
2022-04-11 2:50 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).