linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: kbuild-all@lists.01.org, linux-acpi@vger.kernel.org,
	devel@acpica.org, linux-pm@vger.kernel.org
Subject: [rafael-pm:testing 12/12] drivers/idle/intel_idle.c:1701:17: error: 'disable_promotion_to_c1e' undeclared
Date: Thu, 28 Apr 2022 16:56:19 +0800	[thread overview]
Message-ID: <202204281634.Ho3eVKJ7-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git testing
head:   55ecda6f25ef6de769ae64f162828aee4812c313
commit: 55ecda6f25ef6de769ae64f162828aee4812c313 [12/12] Merge branch 'intel-idle' into linux-next
config: x86_64-randconfig-c001 (https://download.01.org/0day-ci/archive/20220428/202204281634.Ho3eVKJ7-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?id=55ecda6f25ef6de769ae64f162828aee4812c313
        git remote add rafael-pm https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
        git fetch --no-tags rafael-pm testing
        git checkout 55ecda6f25ef6de769ae64f162828aee4812c313
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/idle/intel_idle.c: In function 'adl_idle_state_table_update':
>> drivers/idle/intel_idle.c:1701:17: error: 'disable_promotion_to_c1e' undeclared (first use in this function)
    1701 |                 disable_promotion_to_c1e = true;
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/idle/intel_idle.c:1701:17: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/idle/intel_idle.c:1706:9: error: implicit declaration of function 'c1e_promotion_enable' [-Werror=implicit-function-declaration]
    1706 |         c1e_promotion_enable();
         |         ^~~~~~~~~~~~~~~~~~~~
   drivers/idle/intel_idle.c: At top level:
   drivers/idle/intel_idle.c:1854:13: warning: conflicting types for 'c1e_promotion_enable'; have 'void(void)'
    1854 | static void c1e_promotion_enable(void)
         |             ^~~~~~~~~~~~~~~~~~~~
   drivers/idle/intel_idle.c:1854:13: error: static declaration of 'c1e_promotion_enable' follows non-static declaration
   drivers/idle/intel_idle.c:1706:9: note: previous implicit declaration of 'c1e_promotion_enable' with type 'void(void)'
    1706 |         c1e_promotion_enable();
         |         ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/disable_promotion_to_c1e +1701 drivers/idle/intel_idle.c

64233338499126 Chen Yu   2021-05-28  1685  
cc6e234b826408 Zhang Rui 2022-04-15  1686  /**
cc6e234b826408 Zhang Rui 2022-04-15  1687   * adl_idle_state_table_update - Adjust AlderLake idle states table.
cc6e234b826408 Zhang Rui 2022-04-15  1688   */
cc6e234b826408 Zhang Rui 2022-04-15  1689  static void __init adl_idle_state_table_update(void)
cc6e234b826408 Zhang Rui 2022-04-15  1690  {
cc6e234b826408 Zhang Rui 2022-04-15  1691  	/* Check if user prefers C1 over C1E. */
cc6e234b826408 Zhang Rui 2022-04-15  1692  	if (preferred_states_mask & BIT(1)) {
cc6e234b826408 Zhang Rui 2022-04-15  1693  		if (preferred_states_mask & BIT(2))
cc6e234b826408 Zhang Rui 2022-04-15  1694  			/* Both can't be enabled, stick to the defaults. */
cc6e234b826408 Zhang Rui 2022-04-15  1695  			goto end;
cc6e234b826408 Zhang Rui 2022-04-15  1696  
cc6e234b826408 Zhang Rui 2022-04-15  1697  		cpuidle_state_table[0].flags &= ~CPUIDLE_FLAG_UNUSABLE;
cc6e234b826408 Zhang Rui 2022-04-15  1698  		cpuidle_state_table[1].flags |= CPUIDLE_FLAG_UNUSABLE;
cc6e234b826408 Zhang Rui 2022-04-15  1699  
cc6e234b826408 Zhang Rui 2022-04-15  1700  		/* Disable C1E by clearing the "C1E promotion" bit. */
cc6e234b826408 Zhang Rui 2022-04-15 @1701  		disable_promotion_to_c1e = true;
cc6e234b826408 Zhang Rui 2022-04-15  1702  		return;
cc6e234b826408 Zhang Rui 2022-04-15  1703  	}
cc6e234b826408 Zhang Rui 2022-04-15  1704  end:
cc6e234b826408 Zhang Rui 2022-04-15  1705  	/* Make sure C1E is enabled by default */
cc6e234b826408 Zhang Rui 2022-04-15 @1706  	c1e_promotion_enable();
cc6e234b826408 Zhang Rui 2022-04-15  1707  }
cc6e234b826408 Zhang Rui 2022-04-15  1708  

:::::: The code at line 1701 was first introduced by commit
:::::: cc6e234b8264089d11c34f82d6be925281ca52ba intel_idle: Add AlderLake support

:::::: TO: Zhang Rui <rui.zhang@intel.com>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

                 reply	other threads:[~2022-04-28  8:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204281634.Ho3eVKJ7-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=devel@acpica.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).