From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E9EC433EF for ; Thu, 5 May 2022 15:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381331AbiEEPcC (ORCPT ); Thu, 5 May 2022 11:32:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1381348AbiEEPb7 (ORCPT ); Thu, 5 May 2022 11:31:59 -0400 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.129.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C86A15BE7B for ; Thu, 5 May 2022 08:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651764498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z8QO9rJ6Ts0Rv2clyS7GURk3RsnaSaH+6/9cSSyBhyU=; b=ABzdq8YzfGDZyip84L36XYSC/zVI1CT3+d9sjKq941pIVCM8jXyKWEEAx2sQGU2YYK/Uu0 6OaLV9Br6gh5nWB1KusK62CjbBHxuGkwlsPKqs3ihLv6iEviW0TVwoz//Hmi2UjGClybuu lXGqZDRnR5P/ctfHQGCpjsMohHzvfL8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-xGvgZpQGM86kqzNUweA2yQ-1; Thu, 05 May 2022 11:28:13 -0400 X-MC-Unique: xGvgZpQGM86kqzNUweA2yQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3ADD885A5A8; Thu, 5 May 2022 15:28:12 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.3]) by smtp.corp.redhat.com (Postfix) with SMTP id 1A398463EDE; Thu, 5 May 2022 15:28:06 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 5 May 2022 17:28:11 +0200 (CEST) Date: Thu, 5 May 2022 17:28:03 +0200 From: Oleg Nesterov To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, bigeasy@linutronix.de, Will Deacon , tj@kernel.org, linux-pm@vger.kernel.org, Peter Zijlstra , Richard Weinberger , Anton Ivanov , Johannes Berg , linux-um@lists.infradead.org, Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn , linux-ia64@vger.kernel.org Subject: Re: [PATCH v3 08/11] ptrace: Admit ptrace_stop can generate spuriuos SIGTRAPs Message-ID: <20220505152801.GC13929@redhat.com> References: <87k0b0apne.fsf_-_@email.froward.int.ebiederm.org> <20220504224058.476193-8-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220504224058.476193-8-ebiederm@xmission.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 05/04, Eric W. Biederman wrote: > > -static int ptrace_stop(int exit_code, int why, int clear_code, > - unsigned long message, kernel_siginfo_t *info) > +static int ptrace_stop(int exit_code, int why, unsigned long message, > + kernel_siginfo_t *info) Forgot to mention... but in general I like this change. In particular, I like the fact it kills the ugly "int clear_code" arg which looks as if it solves the problems with the exiting tracer, but actually it doesn't. And we do not really care, imo. Oleg.