From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9879C433FE for ; Wed, 11 May 2022 14:51:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240845AbiEKOvX (ORCPT ); Wed, 11 May 2022 10:51:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245093AbiEKOvD (ORCPT ); Wed, 11 May 2022 10:51:03 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 190544756F; Wed, 11 May 2022 07:50:57 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69684ED1; Wed, 11 May 2022 07:50:57 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CBF2A3F66F; Wed, 11 May 2022 07:50:55 -0700 (PDT) Date: Wed, 11 May 2022 15:50:53 +0100 From: Sudeep Holla To: Pierre Gondois Cc: linuix-kernel@vger.kernel.org, Ionela.Voinescu@arm.com, Sudeep Holla , Dietmar.Eggemann@arm.com, "Rafael J. Wysocki" , Len Brown , Viresh Kumar , Robert Moore , linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, devel@acpica.org Subject: Re: [PATCH v1 5/5] cpufreq: CPPC: Enable dvfs_possible_from_any_cpu Message-ID: <20220511145053.mszsbcqsytf6tmfh@bogus> References: <20220511134559.1466925-1-pierre.gondois@arm.com> <20220511134559.1466925-5-pierre.gondois@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220511134559.1466925-5-pierre.gondois@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, May 11, 2022 at 03:45:59PM +0200, Pierre Gondois wrote: > From: Pierre Gondois > > The communication mean of the _CPC desired performance can be > PCC, System Memory, System IO, or Functional Fixed Hardware (FFH). > > PCC, SystemMemory and SystemIo address spaces are available from any > CPU. Thus, dvfs_possible_from_any_cpu should be enabled in such case. > For FFH, let the FFH implementation do smp_call_function_*() calls. > Fair enough. I just thought it would be good to check if this is already taken care for Arm platforms and found that we don't support it yet. So all is fine :). > Signed-off-by: Pierre Gondois > --- > drivers/cpufreq/cppc_cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 000a0c610c30..ad1535fbf389 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -558,6 +558,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) > } > > policy->fast_switch_possible = cppc_allow_fast_switch(); > + policy->dvfs_possible_from_any_cpu = true; > Reviewed-by: Sudeep Holla -- Regards, Sudeep