From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Christoph Hellwig <hch@lst.de>
Cc: bhelgaas@google.com, lorenzo.pieralisi@arm.com,
kbusch@kernel.org, linux-nvme@lists.infradead.org,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, svarbanov@mm-sol.com,
bjorn.andersson@linaro.org, axboe@fb.com,
quic_vbadigan@quicinc.com, quic_krichai@quicinc.com,
quic_nitirawa@quicinc.com, vidyas@nvidia.com, sagi@grimberg.me,
linux-pm@vger.kernel.org, rafael@kernel.org,
Prasad Malisetty <quic_pmaliset@quicinc.com>
Subject: Re: [PATCH v2 3/3] PCI: qcom: Add system PM support
Date: Wed, 18 May 2022 18:57:57 +0530 [thread overview]
Message-ID: <20220518132757.GC4791@thinkpad> (raw)
In-Reply-To: <20220518132358.GA26902@lst.de>
On Wed, May 18, 2022 at 03:23:58PM +0200, Christoph Hellwig wrote:
> On Wed, May 18, 2022 at 06:49:13PM +0530, Manivannan Sadhasivam wrote:
> > From: Prasad Malisetty <quic_pmaliset@quicinc.com>
> >
> > Add suspend and resume callbacks to handle system suspend and resume in
> > the Qcom PCIe controller driver. When the system suspends, PME turnoff
> > message will be sent to the device and the RC driver will wait for the
> > device to enter L23 Ready state. After that, the PHY will be powered down
> > and clocks/regulators will be disabled.
>
> So what about just not doing this stupid power disabling to start
> with? Unlike x86 where we do not have choice due to the BIOS, we
> apparently do here. And disabling power is the wrong thing to do at
> least for SSDs as it massively increases the wear on the NAND.
That's the requirement the Chromebook based on SC7280 has. I will check
internally and get back.
Thanks,
Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-05-18 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 13:19 [PATCH v2 0/3] PCI: Notify PCI drivers about powerdown during suspend Manivannan Sadhasivam
2022-05-18 13:19 ` [PATCH v2 1/3] PCI: Add a flag to notify " Manivannan Sadhasivam
2022-05-18 13:19 ` [PATCH v2 2/3] nvme-pci: Make use of "suspend_poweroff" flag during system suspend Manivannan Sadhasivam
2022-05-18 13:19 ` [PATCH v2 3/3] PCI: qcom: Add system PM support Manivannan Sadhasivam
2022-05-18 13:23 ` Christoph Hellwig
2022-05-18 13:27 ` Manivannan Sadhasivam [this message]
2022-05-18 13:27 ` [PATCH v2 0/3] PCI: Notify PCI drivers about powerdown during suspend Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518132757.GC4791@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=axboe@fb.com \
--cc=bhelgaas@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=quic_krichai@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pmaliset@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=svarbanov@mm-sol.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).