From: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
To: rafael@kernel.org, daniel.lezcano@linaro.org,
rostedt@goodmis.org, mingo@redhat.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, joao.m.martins@oracle.com,
mtosatti@redhat.com
Cc: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
Subject: [PATCH] cpuidle: haltpoll: Add trace points for guest_halt_poll_ns grow/shrink
Date: Mon, 23 May 2022 06:35:43 +0000 [thread overview]
Message-ID: <20220523063543.99335-1-eiichi.tsukata@nutanix.com> (raw)
Add trace points as are implemented in KVM host halt polling.
This helps tune guest halt polling params.
Signed-off-by: Eiichi Tsukata <eiichi.tsukata@nutanix.com>
---
drivers/cpuidle/governors/haltpoll.c | 7 +++++-
include/trace/events/power.h | 33 ++++++++++++++++++++++++++++
2 files changed, 39 insertions(+), 1 deletion(-)
diff --git a/drivers/cpuidle/governors/haltpoll.c b/drivers/cpuidle/governors/haltpoll.c
index cb2a96eafc02..9a6eca41a484 100644
--- a/drivers/cpuidle/governors/haltpoll.c
+++ b/drivers/cpuidle/governors/haltpoll.c
@@ -19,6 +19,7 @@
#include <linux/sched.h>
#include <linux/module.h>
#include <linux/kvm_para.h>
+#include <trace/events/power.h>
static unsigned int guest_halt_poll_ns __read_mostly = 200000;
module_param(guest_halt_poll_ns, uint, 0644);
@@ -77,13 +78,14 @@ static int haltpoll_select(struct cpuidle_driver *drv,
static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)
{
- unsigned int val;
+ unsigned int val, old;
/* Grow cpu_halt_poll_us if
* cpu_halt_poll_us < block_ns < guest_halt_poll_us
*/
if (block_ns > dev->poll_limit_ns && block_ns <= guest_halt_poll_ns) {
val = dev->poll_limit_ns * guest_halt_poll_grow;
+ old = val;
if (val < guest_halt_poll_grow_start)
val = guest_halt_poll_grow_start;
@@ -91,16 +93,19 @@ static void adjust_poll_limit(struct cpuidle_device *dev, u64 block_ns)
val = guest_halt_poll_ns;
dev->poll_limit_ns = val;
+ trace_guest_halt_poll_ns_grow(smp_processor_id(), val, old);
} else if (block_ns > guest_halt_poll_ns &&
guest_halt_poll_allow_shrink) {
unsigned int shrink = guest_halt_poll_shrink;
val = dev->poll_limit_ns;
+ old = val;
if (shrink == 0)
val = 0;
else
val /= shrink;
dev->poll_limit_ns = val;
+ trace_guest_halt_poll_ns_shrink(smp_processor_id(), val, old);
}
}
diff --git a/include/trace/events/power.h b/include/trace/events/power.h
index af5018aa9517..db065af9c3c0 100644
--- a/include/trace/events/power.h
+++ b/include/trace/events/power.h
@@ -500,6 +500,39 @@ DEFINE_EVENT(dev_pm_qos_request, dev_pm_qos_remove_request,
TP_ARGS(name, type, new_value)
);
+
+TRACE_EVENT(guest_halt_poll_ns,
+
+ TP_PROTO(bool grow, unsigned int cpu_id,
+ unsigned int new, unsigned int old),
+
+ TP_ARGS(grow, cpu_id, new, old),
+
+ TP_STRUCT__entry(
+ __field(bool, grow)
+ __field(unsigned int, cpu_id)
+ __field(unsigned int, new)
+ __field(unsigned int, old)
+ ),
+
+ TP_fast_assign(
+ __entry->grow = grow;
+ __entry->cpu_id = cpu_id;
+ __entry->new = new;
+ __entry->old = old;
+ ),
+
+ TP_printk("cpu %u: halt_poll_ns %u (%s %u)",
+ __entry->cpu_id,
+ __entry->new,
+ __entry->grow ? "grow" : "shrink",
+ __entry->old)
+);
+
+#define trace_guest_halt_poll_ns_grow(cpu_id, new, old) \
+ trace_guest_halt_poll_ns(true, cpu_id, new, old)
+#define trace_guest_halt_poll_ns_shrink(cpu_id, new, old) \
+ trace_guest_halt_poll_ns(false, cpu_id, new, old)
#endif /* _TRACE_POWER_H */
/* This part must be outside protection */
--
2.36.1
next reply other threads:[~2022-05-23 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 6:35 Eiichi Tsukata [this message]
2022-05-23 11:33 ` [PATCH] cpuidle: haltpoll: Add trace points for guest_halt_poll_ns grow/shrink Eiichi Tsukata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523063543.99335-1-eiichi.tsukata@nutanix.com \
--to=eiichi.tsukata@nutanix.com \
--cc=daniel.lezcano@linaro.org \
--cc=joao.m.martins@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox