* [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events
@ 2022-05-26 8:28 Miaoqian Lin
2022-06-18 14:10 ` Chanwoo Choi
2022-06-18 14:18 ` Chanwoo Choi
0 siblings, 2 replies; 3+ messages in thread
From: Miaoqian Lin @ 2022-05-26 8:28 UTC (permalink / raw)
To: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, Krzysztof Kozlowski,
Alim Akhtar, linux-pm, linux-arm-kernel, linux-samsung-soc,
linux-kernel
Cc: linmq006
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
This function only calls of_node_put() in normal path,
missing it in error paths.
Add missing of_node_put() to avoid refcount leak.
Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/devfreq/event/exynos-ppmu.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 9b849d781116..a443e7c42daf 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -519,15 +519,19 @@ static int of_get_devfreq_events(struct device_node *np,
count = of_get_child_count(events_np);
desc = devm_kcalloc(dev, count, sizeof(*desc), GFP_KERNEL);
- if (!desc)
+ if (!desc) {
+ of_node_put(events_np);
return -ENOMEM;
+ }
info->num_events = count;
of_id = of_match_device(exynos_ppmu_id_match, dev);
if (of_id)
info->ppmu_type = (enum exynos_ppmu_type)of_id->data;
- else
+ else {
+ of_node_put(events_np);
return -EINVAL;
+ }
j = 0;
for_each_child_of_node(events_np, node) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events
2022-05-26 8:28 [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events Miaoqian Lin
@ 2022-06-18 14:10 ` Chanwoo Choi
2022-06-18 14:18 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2022-06-18 14:10 UTC (permalink / raw)
To: Miaoqian Lin, Chanwoo Choi, MyungJoo Ham, Kyungmin Park,
Krzysztof Kozlowski, Alim Akhtar, linux-pm, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On 22. 5. 26. 17:28, Miaoqian Lin wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> This function only calls of_node_put() in normal path,
> missing it in error paths.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/devfreq/event/exynos-ppmu.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 9b849d781116..a443e7c42daf 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -519,15 +519,19 @@ static int of_get_devfreq_events(struct device_node *np,
>
> count = of_get_child_count(events_np);
> desc = devm_kcalloc(dev, count, sizeof(*desc), GFP_KERNEL);
> - if (!desc)
> + if (!desc) {
> + of_node_put(events_np);
> return -ENOMEM;
> + }
> info->num_events = count;
>
> of_id = of_match_device(exynos_ppmu_id_match, dev);
> if (of_id)
> info->ppmu_type = (enum exynos_ppmu_type)of_id->data;
> - else
> + else {
> + of_node_put(events_np);
> return -EINVAL;
> + }
>
> j = 0;
> for_each_child_of_node(events_np, node) {
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events
2022-05-26 8:28 [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events Miaoqian Lin
2022-06-18 14:10 ` Chanwoo Choi
@ 2022-06-18 14:18 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2022-06-18 14:18 UTC (permalink / raw)
To: Miaoqian Lin, Chanwoo Choi, MyungJoo Ham, Kyungmin Park,
Krzysztof Kozlowski, Alim Akhtar, linux-pm, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On 22. 5. 26. 17:28, Miaoqian Lin wrote:
> of_get_child_by_name() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> This function only calls of_node_put() in normal path,
> missing it in error paths.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: f262f28c1470 ("PM / devfreq: event: Add devfreq_event class")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/devfreq/event/exynos-ppmu.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 9b849d781116..a443e7c42daf 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -519,15 +519,19 @@ static int of_get_devfreq_events(struct device_node *np,
>
> count = of_get_child_count(events_np);
> desc = devm_kcalloc(dev, count, sizeof(*desc), GFP_KERNEL);
> - if (!desc)
> + if (!desc) {
> + of_node_put(events_np);
> return -ENOMEM;
> + }
> info->num_events = count;
>
> of_id = of_match_device(exynos_ppmu_id_match, dev);
> if (of_id)
> info->ppmu_type = (enum exynos_ppmu_type)of_id->data;
> - else
> + else {
> + of_node_put(events_np);
> return -EINVAL;
> + }
>
> j = 0;
> for_each_child_of_node(events_np, node) {
I edited the patch title with 'PM / ' prefix
in order to keep the consistent style of title as following:
PM / devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-18 14:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-26 8:28 [PATCH] devfreq: exynos-ppmu: Fix refcount leak in of_get_devfreq_events Miaoqian Lin
2022-06-18 14:10 ` Chanwoo Choi
2022-06-18 14:18 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).