public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Sibi Sankar <sibis@codeaurora.org>,
	Saravana Kannan <skannan@codeaurora.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
Subject: [PATCH v4 2/4] PM / devfreq: Fix kernel warning with cpufreq passive register fail
Date: Wed, 15 Jun 2022 01:09:48 +0200	[thread overview]
Message-ID: <20220614230950.426-3-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20220614230950.426-1-ansuelsmth@gmail.com>

When the cpufreq passive register path from the passive governor fails,
the cpufreq_passive_unregister is called and a kernel WARNING is always
reported.
This is caused by the fact that the devfreq driver already call the
governor unregister with the GOV_STOP, for this reason the second
cpufreq_passive_unregister always return error and a WARN is printed
from the WARN_ON function.
Remove the unregister call from the error handling of the cpufreq register
notifier as it's fundamentally wrong and already handled by the devfreq
core code.

Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
Signed-off-by: Christian 'Ansuel' Marangi <ansuelsmth@gmail.com>
---
 drivers/devfreq/governor_passive.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
index 95de336f20d5..dcc9dd518197 100644
--- a/drivers/devfreq/governor_passive.c
+++ b/drivers/devfreq/governor_passive.c
@@ -331,7 +331,6 @@ static int cpufreq_passive_register_notifier(struct devfreq *devfreq)
 err_put_policy:
 	cpufreq_cpu_put(policy);
 err:
-	WARN_ON(cpufreq_passive_unregister_notifier(devfreq));
 
 	return ret;
 }
-- 
2.36.1


  parent reply	other threads:[~2022-06-15  0:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 23:09 [PATCH v4 0/4] PM / devfreq: Various Fixes to cpufreq based passive governor Christian 'Ansuel' Marangi
2022-06-14 23:09 ` [PATCH v4 1/4] PM / devfreq: Fix cpufreq passive unregister erroring on PROBE_DEFER Christian 'Ansuel' Marangi
2022-06-15  6:48   ` Chanwoo Choi
2022-06-15  9:13     ` Ansuel Smith
2022-06-17 18:35       ` Chanwoo Choi
2022-06-14 23:09 ` Christian 'Ansuel' Marangi [this message]
2022-06-15  7:11   ` [PATCH v4 2/4] PM / devfreq: Fix kernel warning with cpufreq passive register fail Chanwoo Choi
2022-06-15  9:20     ` Ansuel Smith
2022-06-17 19:08       ` Chanwoo Choi
2022-06-19 22:19         ` Christian Marangi
2022-06-14 23:09 ` [PATCH v4 3/4] PM / devfreq: Rework freq_table to be local to devfreq struct Christian 'Ansuel' Marangi
2022-06-17 19:33   ` Chanwoo Choi
2022-06-17 19:38     ` Christian Marangi
2022-06-18 13:57       ` Chanwoo Choi
2022-06-14 23:09 ` [PATCH v4 4/4] PM / devfreq: Mute warning on governor PROBE_DEFER Christian 'Ansuel' Marangi
2022-06-15  6:56   ` Chanwoo Choi
2022-06-15  9:22     ` Ansuel Smith
2022-06-17 18:09       ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220614230950.426-3-ansuelsmth@gmail.com \
    --to=ansuelsmth@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sibis@codeaurora.org \
    --cc=skannan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox