From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B8ECCA47C for ; Mon, 4 Jul 2022 13:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233569AbiGDNHp (ORCPT ); Mon, 4 Jul 2022 09:07:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234782AbiGDNHm (ORCPT ); Mon, 4 Jul 2022 09:07:42 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27217FD32 for ; Mon, 4 Jul 2022 06:07:18 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id k14so8542985plh.4 for ; Mon, 04 Jul 2022 06:07:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9vSwpNfijyGK+xrrZ4ktPT+fDOfewidBPv0KVUyPN8w=; b=Daog+0QETcPjLevzyo5ThG79RtkL0CqCom7hkuuYfksUjPFSbwWnYTNzUMbILHd3DI NF1Qu78ynNuVBxEGzjJEW2qnzI3y0NlEbiFDJGw/MChBXZLPJDw4s259eT+D8Q2dqa2O yOnCOXah3RBd3klHMY5xP1wra1/75G4UsvbFKuZDY4PSjMixVMfunsFERDgtnueWwMV3 ND/H2alGaUoJjcDfh6LnEOhOt/TSLoZggVW3qSZeSBlH4a3TDZNNpyT0qs1Ol4svOKNy uWbzHe1aZIJfglIzmsFY1d/CanOtzrCclAfIoT6/1GdK1Tjs+VC2knvI6NRXWMjNBO/8 uJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9vSwpNfijyGK+xrrZ4ktPT+fDOfewidBPv0KVUyPN8w=; b=QXFin62pbAfKoW3ISUtpum0nShXeDVZ/6zbC5fwBJ17gbbu1ffl1WolfC9VlIN0JDm DwEuepMoTMl2SWW7LIlhbX+TV68IqlNLaUFGPgZeuzHo4GDSBfsymgW43R0ldUoPwvr2 vzpZOlra2H8YhTMKWVSlv966i98/SbRvan8yHgnaWFiIGh1zs8b//Ry9Q1Q0eTHg0f1Y 3VJJypGfDdI/rL0k9I9f4MvCDZ+xnk74KgGScQyLPZTVT35GKSJO54+6d626U/Rp3nml e+fxg/gmbczFCXI8rvqLeoiaHTNhcNm0DhbAuyL9+yCMZIeFjCNj3WMGre33aMoGa0Pi rr1g== X-Gm-Message-State: AJIora+4O2lXf1R4D60Yi9wYZMOo+KnvReWJXeP82G4cTTdEoLlMd2j0 0/2JwsfaeBOrgvThJ1rkG94wiQ== X-Google-Smtp-Source: AGRyM1u4sHIQ7MddMLsKSjsK4IcE4neuK6lXp6uptFSzLUxcH3x1D2Q7Xm2DlPLadoDisFpUznRMQw== X-Received: by 2002:a17:903:1108:b0:168:fa61:1456 with SMTP id n8-20020a170903110800b00168fa611456mr36044412plh.162.1656940037531; Mon, 04 Jul 2022 06:07:17 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id 185-20020a6205c2000000b005284d10d8f6sm4577395pff.215.2022.07.04.06.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 06:07:17 -0700 (PDT) Date: Mon, 4 Jul 2022 21:07:12 +0800 From: Leo Yan To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue Subject: Re: [PATCH v3 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag Message-ID: <20220704130712.GD659023@leoy-ThinkPad-X240s> References: <20220704093029.1126609-1-leo.yan@linaro.org> <20220704093029.1126609-2-leo.yan@linaro.org> <18f1ee4a-5787-40d7-2eb5-50a43298845d@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18f1ee4a-5787-40d7-2eb5-50a43298845d@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Jul 04, 2022 at 02:47:13PM +0200, Krzysztof Kozlowski wrote: > On 04/07/2022 11:30, Leo Yan wrote: > > To support path tag in icc-rpm driver, the "#interconnect-cells" > > property is updated as enumerate values: 1 or 2. Setting to 1 means > > it is compatible with old DT binding that interconnect path only > > contains node id; if set to 2 for "#interconnect-cells" property, then > > the second specifier is used as a tag (e.g. vote for which buckets). > > > > Signed-off-by: Leo Yan > > --- > > .../devicetree/bindings/interconnect/qcom,rpm.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml > > index 8a676fef8c1d..cdfe419e7339 100644 > > --- a/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml > > +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml > > @@ -45,7 +45,12 @@ properties: > > - qcom,sdm660-snoc > > > > '#interconnect-cells': > > - const: 1 > > + description: | > > + Number of interconnect specifier. Value: <1> is one cell in a > > + interconnect specifier for the interconnect node id, <2> requires > > + the interconnect node id and an extra path tag. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Ah, too fast. No ack. This ref is also pointless and not explained in > commit msg. I referred other DT binding file for adding $ref to specify property type [1], so it's confused why it's pointless, anyway, I can drop $ref in next spin. Thanks a lot for the review! Leo [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/l2c2x0.yaml#n153