From: Leo Yan <leo.yan@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: Re: [PATCH v3 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag
Date: Mon, 4 Jul 2022 22:12:17 +0800 [thread overview]
Message-ID: <20220704141217.GA961806@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <5fa79e89-144c-7261-335a-8f509b182bba@linaro.org>
On Mon, Jul 04, 2022 at 03:50:41PM +0200, Krzysztof Kozlowski wrote:
[...]
> >>> '#interconnect-cells':
> >>> - const: 1
> >>> + description: |
> >>> + Number of interconnect specifier. Value: <1> is one cell in a
> >>> + interconnect specifier for the interconnect node id, <2> requires
> >>> + the interconnect node id and an extra path tag.
> >>> + $ref: /schemas/types.yaml#/definitions/uint32
> >>
> >> Ah, too fast. No ack. This ref is also pointless and not explained in
> >> commit msg.
> >
> > I referred other DT binding file for adding $ref to specify property
> > type [1], so it's confused why it's pointless, anyway, I can drop $ref
> > in next spin.
> >
> > Thanks a lot for the review!
>
> The "arm,prefetch-offset" is not a cells property.
Understand. Will drop $ref for in new patch.
Thanks,
Leo
next prev parent reply other threads:[~2022-07-04 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 9:30 [PATCH v3 0/5] interconnect: qcom: icc-rpm: Support bucket Leo Yan
2022-07-04 9:30 ` [PATCH v3 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag Leo Yan
2022-07-04 12:46 ` Krzysztof Kozlowski
2022-07-04 12:47 ` Krzysztof Kozlowski
2022-07-04 13:07 ` Leo Yan
2022-07-04 13:50 ` Krzysztof Kozlowski
2022-07-04 14:12 ` Leo Yan [this message]
2022-07-04 9:30 ` [PATCH v3 2/5] interconnect: qcom: Move qcom_icc_xlate_extended() to a common file Leo Yan
2022-07-04 9:30 ` [PATCH v3 3/5] interconnect: qcom: icc-rpm: Change to use qcom_icc_xlate_extended() Leo Yan
2022-07-04 9:30 ` [PATCH v3 4/5] interconnect: qcom: icc-rpm: Support multiple buckets Leo Yan
2022-07-04 9:30 ` [PATCH v3 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220704141217.GA961806@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox