From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2B1BC43334 for ; Tue, 5 Jul 2022 07:31:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231339AbiGEHbq (ORCPT ); Tue, 5 Jul 2022 03:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbiGEHbp (ORCPT ); Tue, 5 Jul 2022 03:31:45 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D7F012D09 for ; Tue, 5 Jul 2022 00:31:43 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id f12so999645pfk.10 for ; Tue, 05 Jul 2022 00:31:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/vepQl1vtemGKmutRdXSKWgV8bQAVH9vge5clbomKgo=; b=L1qnrz27rkhQz4LHaw+WohXWeRTJ+FO92rTugSr1MelYv7j87eg3/A7ZCaYg2XxX+d zADRmzioXyqJ0QjPAbip43nNTnDmn/HTpK22EkosVd0GyggreKuIsjhtbypah0qiTXq5 6FoSsHQELRIY++2dBUqI0vutljIhHaj0HZCz08tQobbCgkXduvpzqovba++poXfRVj7Z kwtR39yD0mGEoRe4zOU4xF5DIMdd9DZFiJ4JSyZdyCol12T8koKE+Ff8UIEujkiWuceb ozz4urXKWXQZ+1p93ka/EEPSDvkfDyVv2vH5+Sjl0ntiURZntRzkR4RhnCScx0MeaJUM x9NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/vepQl1vtemGKmutRdXSKWgV8bQAVH9vge5clbomKgo=; b=hmy8JOe+2YL5mw2om9wRmA+gyNgT7C8x6ULywppnra9S0bscAargRt7OLGaPFYi9tm +WxR+gs4RBqMPi3wUQ+zXpp8zdgLIXcBoSpmIExRp3exRBn0eoVq0bovSoblyiUj4S+f UE/hGxYX1UtPeLmnzoXKuz3XHeC0wR6eaPNqMaTpoSOTZL6/M/FO6GoBbijRb5OW7LG3 clVOVTyHMB2bJsosLP4QXGtcEjmKiKKcd/pXaU7az9xpAXW7rIGi9Zw36t6ocGUu21lA lKLesKEDVDLv7lYZ6OskHWkJcjNR5PfD4uYUEvqO5A9LDgI6CQEMd+t3wfEOzk31OpXI DF8A== X-Gm-Message-State: AJIora+cHd2xv8xINjUxpO13jVTTTWh6NDNOhpGJPx22UjJQU6d8OkM9 o3AZjkV9DgNLW3+fBh/yoTvA6g== X-Google-Smtp-Source: AGRyM1tC2c9uRpOwR3NAGPMCSuyJ244ylPjM7RPK2YJ+20t2d5S8Uik+vb0hyJEhpBe+cbXXTZF08w== X-Received: by 2002:a63:d94a:0:b0:412:6986:326e with SMTP id e10-20020a63d94a000000b004126986326emr3932902pgj.56.1657006302881; Tue, 05 Jul 2022 00:31:42 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([154.3.32.171]) by smtp.gmail.com with ESMTPSA id w18-20020a627b12000000b00527e026591esm12669211pfc.150.2022.07.05.00.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 00:31:42 -0700 (PDT) Date: Tue, 5 Jul 2022 15:31:38 +0800 From: Leo Yan To: Andy Gross , Bjorn Andersson , Georgi Djakov , Bryan O'Donoghue , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] interconnect: qcom: msm8939: Use icc_sync_state Message-ID: <20220705073138.GA180752@leoy-ThinkPad-X240s> References: <20220416012634.479617-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220416012634.479617-1-leo.yan@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Georgi, Bjorn, On Sat, Apr 16, 2022 at 09:26:34AM +0800, Leo Yan wrote: > It's fashion to use the icc_sync_state callback to notify the framework > when all consumers are probed, so that the bandwidth request doesn't > need to stay on maximum value. > > Do the same thing for msm8939 driver. Ping for this patch. This patch is needed for enabling ICC driver on msm8939, I verified it based on Bryan O'Donoghue's DT binding patches. Please see the branch which contains complete patches: https://git.linaro.org/people/leo.yan/linux.git/log/?h=v5.19-rc4%2bicc_sleep_clock_v2 Thanks, Leo > Signed-off-by: Leo Yan > --- > drivers/interconnect/qcom/msm8939.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/interconnect/qcom/msm8939.c b/drivers/interconnect/qcom/msm8939.c > index f9c2d7d3100d..ca5f611d33b0 100644 > --- a/drivers/interconnect/qcom/msm8939.c > +++ b/drivers/interconnect/qcom/msm8939.c > @@ -1423,6 +1423,7 @@ static struct platform_driver msm8939_noc_driver = { > .driver = { > .name = "qnoc-msm8939", > .of_match_table = msm8939_noc_of_match, > + .sync_state = icc_sync_state, > }, > }; > module_platform_driver(msm8939_noc_driver); > -- > 2.25.1 >