From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2346DC433EF for ; Fri, 8 Jul 2022 06:29:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237296AbiGHG3o (ORCPT ); Fri, 8 Jul 2022 02:29:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237245AbiGHG3n (ORCPT ); Fri, 8 Jul 2022 02:29:43 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1926C1A812 for ; Thu, 7 Jul 2022 23:29:42 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id b9so6719629pfp.10 for ; Thu, 07 Jul 2022 23:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OxzlnlJQQW+AJLZaxxRnLlnUnRueupJTmSnVE0o02mw=; b=zEStfvLSPbT+0vqMFAaS74qIUp+eaKV3ktNkqsNvTQSBxYZodYjqZFdOcVoM5aiEhW hfq3BlfBqNnASiqYQSSmA05An0FlDp2NPTaXBf4p9nh9tlscZa0u1Q1tXBPID6thL4vd v/L965NTucQ3/ZDV7GQpKDBXs+NMVOSqx2wTziQCnFyzZfs1VODX7/ik9o+GzHpVfABV tRW2R/K0oBSsjK2u+PdcB+t7ScLB2zwR2w+FLFT0PzheDnPn39A+L61d3zgx+WD/4lOF ZxQWaLNRnVZ7g8BrobxJ52cy23LULENK2+jNrQDWpQp67XrlcDKHr3rzcvU3jE5RNc3G mcPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OxzlnlJQQW+AJLZaxxRnLlnUnRueupJTmSnVE0o02mw=; b=V8sTrr1fo16nAySC0yGlBnfJF+lVQvxxVzuvd1tS97AYWZ6rKIskaNxTnQ5W9+tUal uK3mYUJh8oqXfL5b9DnDlclQlOVtld2Cq56OI8ee25ual7kD8z6EMzIp/78KgKXHvAXA RrH7xRqXhidO8/9/aCogm9Jx/4g6ok4N1s6w3in/4m1MvcVypv8hgxI8HDtI19ysk1S1 N4v0z6Pzx1sxuCZV3y9c1oeeRWL4jAk0qNGflbFE24rAw4M4u0xsOI0mSwaGABv4dFSC +1kPsuBnxIsNAQOKBs4hc9HitCbSpvdX6DFij2Jc/be77I5V9f+U/haNxi+Sez2K5aRT Rl8g== X-Gm-Message-State: AJIora+sDDTiQ9DMWtyoiWESkQv1kt4cxw3HWdw2+UY8pJalf/Tev33/ 2xV4pcHveYyTfFlO2NqQHeXWeA== X-Google-Smtp-Source: AGRyM1vx5F5PLe2M6kbtNv22VitB1eggD2eJ+w2NdziPJN4Sg8QPSijHXrkDRjBNReGg3SnuseQCvQ== X-Received: by 2002:a65:430a:0:b0:412:1877:7def with SMTP id j10-20020a65430a000000b0041218777defmr1946422pgq.93.1657261781329; Thu, 07 Jul 2022 23:29:41 -0700 (PDT) Received: from leoy-ThinkPad-X240s (n058152077182.netvigator.com. [58.152.77.182]) by smtp.gmail.com with ESMTPSA id bk21-20020aa78315000000b005254e44b748sm27802126pfb.84.2022.07.07.23.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 23:29:40 -0700 (PDT) Date: Fri, 8 Jul 2022 14:29:36 +0800 From: Leo Yan To: Georgi Djakov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/5] interconnect: qcom: icc-rpm: Support multiple buckets Message-ID: <20220708062936.GA195591@leoy-ThinkPad-X240s> References: <20220705072336.742703-1-leo.yan@linaro.org> <20220705072336.742703-5-leo.yan@linaro.org> <1d0fec7d-ed83-e1ff-92a1-e721bcc50298@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d0fec7d-ed83-e1ff-92a1-e721bcc50298@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Jul 07, 2022 at 05:29:16PM +0300, Georgi Djakov wrote: [...] > > +/** > > + * qcom_icc_rpm_pre_bw_aggregate - cleans up values before re-aggregate requests > > This does not match with the name of the function below. Will fix it. > > + * @node: icc node to operate on > > + */ > > +static void qcom_icc_pre_bw_aggregate(struct icc_node *node) Thanks, Leo