From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: quic_manafm@quicinc.com, rui.zhang@intel.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Amit Kucheria <amitk@kernel.org>
Subject: [PATCH v2 1/3] thermal/core: Encapsulate the trip point crossed function
Date: Fri, 8 Jul 2022 20:32:07 +0200 [thread overview]
Message-ID: <20220708183210.1334839-1-daniel.lezcano@linaro.org> (raw)
The routine where the trip point crossed is detected is a strategic
place where different processing will happen. Encapsulate the code in
a function, so all specific actions related with a trip point crossed
can be grouped.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/thermal_core.c | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index cdc0552e8c42..d9f771b15ed8 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -358,6 +358,25 @@ static void handle_critical_trips(struct thermal_zone_device *tz,
tz->ops->critical(tz);
}
+static void handle_thermal_trip_crossed(struct thermal_zone_device *tz, int trip,
+ int trip_temp, int trip_hyst, enum thermal_trip_type trip_type)
+{
+ if (tz->last_temperature == THERMAL_TEMP_INVALID)
+ return;
+
+ if (tz->last_temperature < trip_temp &&
+ tz->temperature >= trip_temp) {
+ thermal_notify_tz_trip_up(tz->id, trip,
+ tz->temperature);
+ }
+
+ if (tz->last_temperature >= trip_temp &&
+ tz->temperature < (trip_temp - trip_hyst)) {
+ thermal_notify_tz_trip_down(tz->id, trip,
+ tz->temperature);
+ }
+}
+
static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
{
enum thermal_trip_type type;
@@ -372,16 +391,7 @@ static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
if (tz->ops->get_trip_hyst)
tz->ops->get_trip_hyst(tz, trip, &hyst);
- if (tz->last_temperature != THERMAL_TEMP_INVALID) {
- if (tz->last_temperature < trip_temp &&
- tz->temperature >= trip_temp)
- thermal_notify_tz_trip_up(tz->id, trip,
- tz->temperature);
- if (tz->last_temperature >= trip_temp &&
- tz->temperature < (trip_temp - hyst))
- thermal_notify_tz_trip_down(tz->id, trip,
- tz->temperature);
- }
+ handle_thermal_trip_crossed(tz, trip, trip_temp, hyst, type);
if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
handle_critical_trips(tz, trip, type);
--
2.25.1
next reply other threads:[~2022-07-08 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 18:32 Daniel Lezcano [this message]
2022-07-08 18:32 ` [PATCH v2 2/3] thermal/core: Passing a parameter instead of calling the function again Daniel Lezcano
2022-07-12 11:14 ` Lukasz Luba
2022-07-12 18:16 ` Rafael J. Wysocki
2022-07-08 18:32 ` [PATCH v2 3/3] thermal/core: Fix thermal trip cross point Daniel Lezcano
2022-07-12 11:29 ` Lukasz Luba
2022-07-12 12:30 ` Daniel Lezcano
2022-07-12 12:40 ` Lukasz Luba
2022-07-12 13:06 ` Daniel Lezcano
2022-07-12 14:28 ` Lukasz Luba
2022-07-12 10:37 ` [PATCH v2 1/3] thermal/core: Encapsulate the trip point crossed function Daniel Lezcano
2022-07-12 11:13 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708183210.1334839-1-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_manafm@quicinc.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).