From: Leo Yan <leo.yan@linaro.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values
Date: Tue, 12 Jul 2022 09:28:23 +0800 [thread overview]
Message-ID: <20220712012823.GA10379@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <480d38db-3114-29d1-8b81-b35a07623060@kernel.org>
Hi Georgi,
On Mon, Jul 11, 2022 at 04:53:47PM +0300, Georgi Djakov wrote:
[...]
> > static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> > {
> > struct qcom_icc_provider *qp;
> > struct qcom_icc_node *src_qn = NULL, *dst_qn = NULL;
> > struct icc_provider *provider;
> > - struct icc_node *n;
> > u64 sum_bw;
> > - u64 max_peak_bw;
> > u64 rate;
> > - u32 agg_avg = 0;
> > - u32 agg_peak = 0;
> > + u64 agg_avg[QCOM_ICC_NUM_BUCKETS], agg_peak[QCOM_ICC_NUM_BUCKETS];
> > + u64 max_agg_avg, max_agg_peak;
>
> Now max_agg_peak is unused?
Sorry for this mistake. Will send new patch series soon.
Thanks,
Leo
prev parent reply other threads:[~2022-07-12 1:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 11:52 [PATCH v5 0/5] interconnect: qcom: icc-rpm: Support bucket Leo Yan
2022-07-11 11:52 ` [PATCH v5 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag Leo Yan
2022-07-11 11:52 ` [PATCH v5 2/5] interconnect: qcom: Move qcom_icc_xlate_extended() to a common file Leo Yan
2022-07-11 11:52 ` [PATCH v5 3/5] interconnect: qcom: icc-rpm: Change to use qcom_icc_xlate_extended() Leo Yan
2022-07-11 11:52 ` [PATCH v5 4/5] interconnect: qcom: icc-rpm: Support multiple buckets Leo Yan
2022-07-11 11:52 ` [PATCH v5 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values Leo Yan
2022-07-11 13:53 ` Georgi Djakov
2022-07-12 1:28 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712012823.GA10379@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox