From: Viresh Kumar <viresh.kumar@linaro.org>
To: Perry Yuan <Perry.Yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Ray.Huang@amd.com,
Deepak.Sharma@amd.com, Mario.Limonciello@amd.com,
Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
Jinzhou.Su@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
Li.Meng@amd.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v3 13/13] cpufreq: CPPC: remove the acpi_disabled check
Date: Wed, 13 Jul 2022 10:59:44 +0530 [thread overview]
Message-ID: <20220713052944.xpk4fi7nuj6rmekd@vireshk-i7> (raw)
In-Reply-To: <d36d38953cf819d89eb9be4d1a2baa5b5feeb52a.1657638462.git.Perry.Yuan@amd.com>
On 12-07-22, 11:43, Perry Yuan wrote:
> "acpi_cpc_valid" function already includes the acpi_disabled check and we can
> remove the duplicated check here
>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 24eaf0ec344d..9adb7612993e 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void)
> {
> int ret;
>
> - if ((acpi_disabled) || !acpi_cpc_valid())
> + if (!acpi_cpc_valid())
> return -ENODEV;
>
> cppc_check_hisi_workaround();
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
prev parent reply other threads:[~2022-07-13 5:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 15:32 [PATCH v3 00/13] AMD Pstate Enhancement And Issue Fixs Perry Yuan
2022-07-12 15:35 ` [PATCH v3 01/13] x86/msr: Add the MSR definition for AMD CPPC hardware control Perry Yuan
2022-07-12 15:39 ` [PATCH v3 02/13] cpufreq: amd-pstate: enable AMD Precision Boost mode switch Perry Yuan
2022-07-12 15:40 ` [PATCH v3 03/13] cpufreq: amd-pstate: cleanup the unused and duplicated headers declaration Perry Yuan
2022-07-13 5:27 ` Viresh Kumar
2022-07-12 15:40 ` [PATCH v3 04/13] cpufreq: amd-pstate: prefetch cppc_req_cached value in amd_pstate_cpu_init() Perry Yuan
2022-07-13 5:27 ` Viresh Kumar
2022-07-13 5:57 ` Yuan, Perry
2022-07-12 15:40 ` [PATCH v3 05/13] cpufreq: amd-pstate: simplify cpudata pointer assignment Perry Yuan
2022-07-13 5:27 ` Viresh Kumar
2022-07-12 15:41 ` [PATCH v3 06/13] cpufreq: amd_pstate: fix wrong lowest perf fetch Perry Yuan
2022-07-13 5:27 ` Viresh Kumar
2022-07-12 15:41 ` [PATCH v3 07/13] cpufreq: amd_pstate: map desired perf into pstate scope for powersave governor Perry Yuan
2022-07-12 15:41 ` [PATCH v3 08/13] cpufreq: amd-pstate: fix white-space Perry Yuan
2022-07-13 5:28 ` Viresh Kumar
2022-07-12 15:42 ` [PATCH v3 09/13] cpufreq: amd-pstate: update pstate frequency transition delay time Perry Yuan
2022-07-13 5:28 ` Viresh Kumar
2022-07-12 15:42 ` [PATCH v3 10/13] cpufreq: amd-pstate: add ACPI disabled check in acpi_cpc_valid() Perry Yuan
2022-07-12 15:42 ` [PATCH v3 11/13] cpufreq: amd_pstate: update transition delay time to 1ms Perry Yuan
2022-07-13 5:29 ` Viresh Kumar
2022-07-12 15:43 ` [PATCH v3 12/13] arch_topology: remove the acpi_disabled check Perry Yuan
2022-07-13 5:29 ` Viresh Kumar
2022-07-13 14:40 ` Sudeep Holla
2022-07-12 15:43 ` [PATCH v3 13/13] cpufreq: CPPC: " Perry Yuan
2022-07-13 5:29 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713052944.xpk4fi7nuj6rmekd@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xinmei.Huang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).