From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEC6CCA479 for ; Wed, 13 Jul 2022 05:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234512AbiGMFcp (ORCPT ); Wed, 13 Jul 2022 01:32:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234421AbiGMFbH (ORCPT ); Wed, 13 Jul 2022 01:31:07 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C276B9DB2 for ; Tue, 12 Jul 2022 22:29:49 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id cp18-20020a17090afb9200b001ef79e8484aso2849054pjb.1 for ; Tue, 12 Jul 2022 22:29:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=73CbFZyz5/Oh4NJ0Bvz1lGW0c6O6K5fxXQrseozXHcw=; b=Rbrcne9hJO5zFt0sQ2gZynRRzzWRe5SVR1wRHlRMHAKMVaSR6X+f7wxY71QYwDLec5 s1z9K4AKE3ujnTmHO73UkxpIQcmIopjo41Z9xVevoud6Y6vZagu0xcBbMD8l4JZtcqYA eidITirbBSI0SmJx9c5CY2c3yzVBlDgFSPxAkbPnxz8wdCsVE3EBxJRs17Ih9ca1Jk/1 7sGzaQqZEthak1timNppoSF+bPzgKtq3FSNQHLZk8mJoxTEwWDvitnTP5Kcac0JeTYEY BBN32x3b30jEKItgp+Seb0c+QCGKPsdYwz4eOjF2zQD8xoA55OtPd7ycjv6siuOA/KIK t/cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=73CbFZyz5/Oh4NJ0Bvz1lGW0c6O6K5fxXQrseozXHcw=; b=5gIUz6IcnAhJdCpiCRWwTqKemj7G2/CAIdl0YjW6/2TI7vrx3DUeLszFZ/G4QdbtId +glTLITnpyNy1sshfxxX8aAoW3eesrWO171roVv2yT1DrAqo81bPRY4dcMo3+3w3U9cv IZfZ1jc9ab2/YKWSAVxNQoyOuvQ7fV/HZQFWr/PpB7MaddB4AUWuBU5NOwcUpwM1CK5s iWceNwu1ga/YDDY0WtJ4e+obdHvQolD38Wl6H1a7oN921FZxqXPOn9eGHL3D3knguKfK rBM6EePP7yR20Q3nfjifKZsf1oY5wiEOKiU5wHRmzffOa72oZslbgafCPEVQmm39dsG3 YanA== X-Gm-Message-State: AJIora82Bf6guROzSE4fkNr34rD7iAbEPVVVcAI89rg5cYa4STbMjxsg 8dv3fSg/tAPgfuUQHIevocZNBw== X-Google-Smtp-Source: AGRyM1suN/HlXdQcKewriih20qhQdaYhuVcOHxFq9ixS+8B1rNZ4ZjRmQjrryfvQPl5jijyUwIbL5Q== X-Received: by 2002:a17:90b:4c8c:b0:1ef:bff6:c964 with SMTP id my12-20020a17090b4c8c00b001efbff6c964mr1892390pjb.36.1657690188493; Tue, 12 Jul 2022 22:29:48 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id m17-20020a170902bb9100b0016a1e2d148csm7809072pls.32.2022.07.12.22.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 22:29:48 -0700 (PDT) Date: Wed, 13 Jul 2022 10:59:44 +0530 From: Viresh Kumar To: Perry Yuan Cc: rafael.j.wysocki@intel.com, Ray.Huang@amd.com, Deepak.Sharma@amd.com, Mario.Limonciello@amd.com, Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com, Jinzhou.Su@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH v3 13/13] cpufreq: CPPC: remove the acpi_disabled check Message-ID: <20220713052944.xpk4fi7nuj6rmekd@vireshk-i7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 12-07-22, 11:43, Perry Yuan wrote: > "acpi_cpc_valid" function already includes the acpi_disabled check and we can > remove the duplicated check here > > Signed-off-by: Perry Yuan > --- > drivers/cpufreq/cppc_cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c > index 24eaf0ec344d..9adb7612993e 100644 > --- a/drivers/cpufreq/cppc_cpufreq.c > +++ b/drivers/cpufreq/cppc_cpufreq.c > @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void) > { > int ret; > > - if ((acpi_disabled) || !acpi_cpc_valid()) > + if (!acpi_cpc_valid()) > return -ENODEV; > > cppc_check_hisi_workaround(); Acked-by: Viresh Kumar -- viresh