From: Viresh Kumar <viresh.kumar@linaro.org>
To: Liang He <windhl@126.com>
Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] OPP: Fix two refcount bugs
Date: Mon, 18 Jul 2022 14:08:22 +0530 [thread overview]
Message-ID: <20220718083822.66red4tg2kcli3zu@vireshk-i7> (raw)
In-Reply-To: <4af1805a.2b51.182106c170c.Coremail.windhl@126.com>
On 18-07-22, 16:28, Liang He wrote:
> At 2022-07-18 15:08:48, "Viresh Kumar" <viresh.kumar@linaro.org> wrote:
> But is it OK if the two patches change the same file at same time？
Yes.
> I wonder if this will trouble you to merge them later.
If I apply the patches in the same order you send them (based on patch numbers
in subject), it will never be a problem.
> After I read the code, I think it is better to drop opp_table->np in '_opp_table_kref_release'
> just like we do for the 'opp->np' in '_opp_kref_release'.
Yeah, look fine, though a review after the new version will make it more clear.
--
viresh
prev parent reply other threads:[~2022-07-18 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 14:47 [PATCH] OPP: Fix two refcount bugs Liang He
2022-07-18 7:08 ` Viresh Kumar
2022-07-18 7:26 ` Viresh Kumar
2022-07-18 8:28 ` Liang He
2022-07-18 8:38 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718083822.66red4tg2kcli3zu@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=vireshk@kernel.org \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox